[Bug 967401] Review Request: vmtouch - Portable file system cache diagnostics and control

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=967401

Douglas Schilling Landgraf <dougsland@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #1 from Douglas Schilling Landgraf <dougsland@xxxxxxxxxx> ---
Hi Robin,

I have few questions:

1) 
BuildRequires:  /usr/bin/dos2unix
BuildRequires:  /usr/bin/mac2unix

What about replace with:

BuildRequires: dos2unix ?

$ rpm -qf /usr/bin/dos2unix
dos2unix-6.0.1-1.fc18.x86_64
$ rpm -qf /usr/bin/mac2unix
dos2unix-6.0.1-1.fc18.x86_64

2)
%build
cc %{optflags} -o %{name} %{name}.c

Why not "make %{?_smp_mflags}" ?
https://fedoraproject.org/wiki/PackagingGuidelines#Parallel_make

Thanks
Douglas

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IDtf2xQvew&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]