https://bugzilla.redhat.com/show_bug.cgi?id=915864 --- Comment #25 from Steven Dake <sdake@xxxxxxxxxx> --- Jimmy, getting really close! Forgive the missed review points from previous reviews - this is my first java package review and I want to make sure I get it right. BLOCKERS: from https://fedoraproject.org/wiki/Packaging:Java 1. https://fedoraproject.org/wiki/Packaging:Java#BuildRequires_and_Requires BuildRequires: java-devel [>= specific_version] BuildRequires: jpackage-utils 2. I believe the java packages that don't include the c++ binary (the TPM file) should be noarch, but could you test to make certain? 3. http://fedoraproject.org/wiki/Packaging/Guidelines#RequiringBasePackage Read that and see if it applies to this package. I am uncertain if client should require the parent package or not (eg: if it is a server agent vs a server application it should not) Regards -steve -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MHLb9Ar5Jm&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review