https://bugzilla.redhat.com/show_bug.cgi?id=915864 --- Comment #24 from Steven Dake <sdake@xxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Packages have proper BuildRequires/Requires on jpackage-utils See: https://fedoraproject.org/wiki/Packaging:Java - Fully versioned dependency in subpackages, if present. Note: Missing: Requires: %{name} = %{version}-%{release} in oat-appraiser, oat-client, oat-commandtool, oat-doc See: http://fedoraproject.org/wiki/Packaging/Guidelines#RequiringBasePackage ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [!]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in oat- appraiser , oat-client , oat-commandtool , oat-doc , oat-javadoc [!]: Package complies to the Packaging Guidelines [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "Unknown or generated". 54 files have unknown license. Detailed output of licensecheck in /home/sdake/915864-oat/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Large documentation must go in a -doc subpackage. Note: Documentation size is 30720 bytes in 3 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: %config files are marked noreplace or the reason is justified. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: oat-appraiser-1.6.0-5.fc20.x86_64.rpm oat-client-1.6.0-5.fc20.x86_64.rpm oat-commandtool-1.6.0-5.fc20.x86_64.rpm oat-doc-1.6.0-5.fc20.x86_64.rpm oat-javadoc-1.6.0-5.fc20.x86_64.rpm oat-appraiser.x86_64: W: no-manual-page-for-binary NIARL_TPM_Module oat-client.x86_64: W: only-non-binary-in-usr-lib oat-commandtool.x86_64: W: no-manual-page-for-binary oat_cert oat-commandtool.x86_64: W: no-manual-page-for-binary oat_oem oat-commandtool.x86_64: W: no-manual-page-for-binary oat_host oat-commandtool.x86_64: W: no-manual-page-for-binary oat_mle oat-commandtool.x86_64: W: no-manual-page-for-binary oat_mle_search oat-commandtool.x86_64: W: no-manual-page-for-binary oat_view_oem oat-commandtool.x86_64: W: no-manual-page-for-binary oat_view_mle oat-commandtool.x86_64: W: no-manual-page-for-binary oat_os oat-commandtool.x86_64: W: no-manual-page-for-binary oat_pcrwhitelist oat-commandtool.x86_64: W: no-manual-page-for-binary oat_pollhosts oat-commandtool.x86_64: W: no-manual-page-for-binary oat_view_os 5 packages and 0 specfiles checked; 0 errors, 13 warnings. Requires -------- oat-javadoc (rpmlib, GLIBC filtered): jpackage-utils oat-appraiser (rpmlib, GLIBC filtered): /bin/bash apache-commons-beanutils apache-commons-cli apache-commons-codec apache-commons-collections apache-commons-digester apache-commons-discovery apache-commons-logging bouncycastle c3p0 codemodel config(oat-appraiser) dom4j geronimo-jta glassfish-fastinfoset glassfish-gmbal glassfish-ha-api glassfish-jaxb glassfish-jaxws glassfish-jaxws-tools glassfish-management-api glassfish-pfl glassfish-policy hibernate-commons-annotations hibernate-jpa-2.0-api hibernate3 httpd istack-commons jackson jakarta-commons-httpclient javassist jersey jsr-311 libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libtspi.so.1()(64bit) log4j mimepull mysql mysql-connector-java mysql-server objectweb-asm php php-mysql rngom rtld(GNU_HASH) slf4j stax-ex tomcat tomcat-servlet-3.0-api txw2 woodstox-core xerces-j2 xml-commons-apis xml-commons-resolver xmlstreambuffer xsom oat-client (rpmlib, GLIBC filtered): /bin/bash /bin/sh apache-commons-beanutils apache-commons-cli apache-commons-codec apache-commons-collections apache-commons-digester apache-commons-discovery apache-commons-logging bouncycastle c3p0 codemodel config(oat-client) dom4j geronimo-jta glassfish-fastinfoset glassfish-gmbal glassfish-ha-api glassfish-jaxb glassfish-jaxws glassfish-jaxws-tools glassfish-management-api glassfish-pfl glassfish-policy hibernate-commons-annotations hibernate-jpa-2.0-api hibernate3 istack-commons jackson jakarta-commons-httpclient java-1.7.0-openjdk javassist jersey jsr-311 log4j mimepull mysql-connector-java objectweb-asm rngom slf4j stax-ex systemd tomcat-servlet-3.0-api trousers txw2 woodstox-core xerces-j2 xml-commons-apis xml-commons-resolver xmlstreambuffer xsom oat-commandtool (rpmlib, GLIBC filtered): /bin/bash curl openssl oat-doc (rpmlib, GLIBC filtered): Provides -------- oat-javadoc: oat-javadoc oat-javadoc(x86-64) oat-appraiser: config(oat-appraiser) oat-appraiser oat-appraiser(x86-64) oat-client: config(oat-client) oat-client oat-client(x86-64) oat-commandtool: oat-commandtool oat-commandtool(x86-64) oat-doc: oat-doc oat-doc(x86-64) Source checksums ---------------- https://github.com/OpenAttestation/OpenAttestation/archive/v1.6.0/OpenAttestation-1.6.0.tar.gz : CHECKSUM(SHA256) this package : 608aa58bb9afeea8e059bb0cb5c9be49711df1dd7a84c6fbeb1a61848149017b CHECKSUM(SHA256) upstream package : 608aa58bb9afeea8e059bb0cb5c9be49711df1dd7a84c6fbeb1a61848149017b Generated by fedora-review 0.4.1 (b2e211f) last change: 2013-04-29 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 915864 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xGlksEouam&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review