https://bugzilla.redhat.com/show_bug.cgi?id=909674 --- Comment #4 from Matthias Runge <mrunge@xxxxxxxxxx> --- (In reply to Christopher Meng from comment #3) > Your spec is invalid. > > 1)Why did you global many things? > > Just put ryu as %{name}, why %global name ryu? > > It's weird... > > 2)%global release 1 is wrong , you should not define this, please write > 1%{?dist} to the release tag. Once you update the spec or package, bump the > 1 to 2 or even higher. > > 3)Prefix: %{_prefix} I don't know why you add this? > > 4)Please take a look at python packaging guidelines,then modify the "python > setup.py build" command. > > 5)Do not use %{buildroot} and $RPM_BUILD_ROOT in one spec, please choose > only one of them. > > 6)Do not %files -f INSTALLED_FILES, please list all files manually Christopher, instead of just saying: this is wrong and that is wrong, you should point ymht(???) to the right direction, as Eduardo already did. ymht: when specifying name: bla, there's no need to %global or %define name any more. The same applies to release, version, etc. python setup.py ... should be written %{__python} setup.py ... -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2n6VqNkCgb&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review