[Bug 909674] Review Request: Ryu - Network operating system and Openflow controller

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=909674

Christopher Meng <cickumqt@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cickumqt@xxxxxxxxx

--- Comment #3 from Christopher Meng <cickumqt@xxxxxxxxx> ---
Your spec is invalid.

1)Why did you global many things?

Just put ryu as %{name}, why %global name ryu?

It's weird...

2)%global release 1 is wrong , you should not define this, please write
1%{?dist} to the release tag. Once you update the spec or package, bump the 1
to 2 or even higher.

3)Prefix: %{_prefix} I don't know why you add this?

4)Please take a look at python packaging guidelines,then modify the "python
setup.py build" command.

5)Do not use %{buildroot} and $RPM_BUILD_ROOT in one spec, please choose only
one of them.

6)Do not %files -f INSTALLED_FILES, please list all files manually

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Bsnzja44M7&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]