https://bugzilla.redhat.com/show_bug.cgi?id=962029 --- Comment #3 from Wolfgang Ulbrich <chat-to-me@xxxxxxxxx> --- The package needs some work! MUST 1. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v3)", "GPL (v2 or later)", "Unknown or generated". 92 files have unknown license. Detailed output of licensecheck in ------------------------------------------------------------------------ GPL (v2 or later) ----------------- /var/lib/mock/fedora-19-x86_64/root/builddir/build/BUILD/libdbusmenu-12.10.2/libdbusmenu-12.10.2/ltmain.sh /var/lib/mock/fedora-19-x86_64/root/builddir/build/BUILD/libdbusmenu-12.10.2/libdbusmenu-gtk3-12.10.2/ltmain.sh GPL (v3) -------- /var/lib/mock/fedora-19-x86_64/root/builddir/build/BUILD/libdbusmenu-12.10.2/libdbusmenu-12.10.2/tests/glib-server-nomenu.c /var/lib/mock/fedora-19-x86_64/root/builddir/build/BUILD/libdbusmenu-12.10.2/libdbusmenu-12.10.2/tests/json-loader.c /var/lib/mock/fedora-19-x86_64/root/builddir/build/BUILD/libdbusmenu-12.10.2/libdbusmenu-12.10.2/tests/json-loader.h /var/lib/mock/fedora-19-x86_64/root/builddir/build/BUILD/libdbusmenu-12.10.2 <snip> Unknown or generated -------------------- /var/lib/mock/fedora-19-x86_64/root/builddir/build/BUILD/libdbusmenu-12.10.2/libdbusmenu-12.10.2/libdbusmenu-glib/client-marshal.c /var/lib/mock/fedora-19-x86_64/root/builddir/build/BUILD/libdbusmenu-12.10.2/libdbusmenu-12.10.2/libdbusmenu-glib/client-marshal.h /var/lib/mock/fedora-19-x86_64/root/builddir/build/BUILD/libdbusmenu-12.10.2/libdbusmenu-12.10.2/libdbusmenu-glib/client-menuitem.c <snip> ------------------------------------------------------------------------------ detailed output is attached. Your package use GPL (v2 or later) and GPL (v3) which is in one term GPLv2+. So change license field to License: GPLv2+ 2. [!]: Package does not own files or directories owned by other packages. %dir %{_libdir}/girepository-1.0/ Your package owns the whole folder in -main, -gtk2 and -gtk3 package. But it is already owned by gobject-introspection. Please remove those lines. 3. Pls add Requires: %{name} = %{version}-%{release} to -doc subpackage, otherwise it's possible to install the doc package without the main package. Don't use the the isa tag here, this will cause an install error. OTHERS: 4. [rave@mother srpm-unpacked]$ rpmlint -i libdbusmenu.spec libdbusmenu.spec:140: W: macro-in-comment %{buildroot} There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. libdbusmenu.spec:140: W: macro-in-comment %{_libexecdir} There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. libdbusmenu.spec:151: W: macro-in-comment %{buildroot} There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. libdbusmenu.spec:151: W: macro-in-comment %{_libexecdir} There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. libdbusmenu.spec:251: W: macro-in-comment %{_libexecdir} There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. libdbusmenu.spec:62: W: mixed-use-of-spaces-and-tabs (spaces: line 62, tab: line 1) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. 0 packages and 1 specfiles checked; 0 errors, 6 warnings. ------------------------------------------------------------ Pls, fix mixed-use-of-spaces-and-tabs. I prefer spaces, in result the spec file looks same in all editors. The other warning you can easyly fix, change i.e # chrpath --delete %{buildroot}%{_libexecdir}/dbusmenu-dumper to # chrpath --delete %%{buildroot}%%{_libexecdir}/dbusmenu-dumper or remove those comment out lines from spec file. 5. %files docs %doc %{name}-%{version}/README %doc %{name}-%{version}/COPYING %doc %{name}-%{version}/COPYING.2.1 %doc %{name}-%{version}/AUTHORS I propose to simplify it before. %doc README COPYING COPYING.2.1 AUTHORS This installs all the docs to /usr/share/doc/%{name}-%{version}/ . The rest looks good. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=psrc9Gt1NC&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review