[Bug 961907] Review Request: rubygem-moped - A MongoDB driver for Ruby

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=961907

--- Comment #3 from Josef Stribny <jstribny@xxxxxxxxxx> ---
* Use latest version when possible
  Last upstream version is 1.5.0

* Run specs in %check section
  Upstream provides specs [1], so please include them in the SRPM and run them.

* Check against Ruby 2.0
  Build seems to be failing on travis [2] for Ruby 2.0, please investigate and
work with upstream on fixing this.

* Don't include files not necessary for runtime in the main package unless it's
a licence
  CHANGELOG.md and README.md should go to %doc sub-package, LICENSE file should
be kept in the main package.

* Avoid trailing whitespace in the spec file

* Make the description a bit more descriptive so it's more usuful
  There is no point of having the same Summary and Description sections.


[1] https://github.com/mongoid/moped/tree/master/spec
[2] https://travis-ci.org/mongoid/moped/jobs/7330302

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iX8Pw4zaeG&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]