https://bugzilla.redhat.com/show_bug.cgi?id=822294 Jason Tibbitts <tibbs@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rspanton@xxxxxxxxxx Flags| |needinfo?(rspanton@zepler.n | |et) --- Comment #3 from Jason Tibbitts <tibbs@xxxxxxxxxxx> --- I am triaging old review tickets. I can't promise a review if you reply, but by closing out the stale tickets we can devote extra attention to the ones which aren't stale. Unfortunately I have no way at all to even test this, and I suspect the other prospective reviewers are in the same boat. It's quite a simple package, though; on a quick inspection I can only see two issues: We have guidelines relating to packaging tarballs from github, which you should follow instead of just saying that you generated a snapshot from git. http://fedoraproject.org/wiki/Packaging:SourceURL#Github There is no need to clean the buildroot at the beginning of %install. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jxJcH8kqjG&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review