Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=964161 Kalev Lember <kalevlember@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |kalevlember@xxxxxxxxx --- Comment #2 from Kalev Lember <kalevlember@xxxxxxxxx> --- Taking for review. Some issues about packaging, in no particular order: 1) Don't set Epoch in new packages, the field should be left out (and delete all references to %{epoch} below) 2) The description and summary should reflect that this is a compatibility package only, similar to what http://pkgs.fedoraproject.org/cgit/libpng12.git/tree/libpng12.spec has 3) I would kill off the static .a libraries and the -static subpackage for a compat package like this 4) It doesn't build: > $ rpmbuild -ba libpng15.spec > [...] > + cd libpng15-1.5.13 > /var/tmp/rpm-tmp.WgkPQ3: line 35: cd: libpng15-1.5.13: No such file or directory Use '%setup -q -n libpng-%{version}' to fix this. 5) Requires: pkgconfig%{?_isa} is superfluous, the pkgconfig dep is already automatically generated by rpmbuild. (If you fix it here, also do it in the libpng 1.6 package, please) 6) -devel subpackage, if you decide to ship it, should have explicit Conflicts: libpng-devel, because the file names overlap. 7) The man pages in the main package are going to conflict between libpng15 and libpng, which need to be parallel installable. Move them to -devel if you decide to ship it, or just remove if not. I'd recommend only shipping the LICENSE file and the libs in the main package: %files %doc LICENSE %{_libdir}/libpng15.so.* 8) example.c and libpng-manual.txt are developer oriented and should go to -devel package %doc instead (both in libpng15 and libpng 1.6 packages) 9) Add a %changelog entry saying that this is a renamed package -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BhLerJzXWh&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review