Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=963693 Michal Srb <msrb@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(msrb@xxxxxxxxxx) | --- Comment #2 from Michal Srb <msrb@xxxxxxxxxx> --- Spec URL: http://msrb.fedorapeople.org/review/2/jenkins-commons-jelly.spec SRPM URL: http://msrb.fedorapeople.org/review/2/jenkins-commons-jelly-1.1.20120928-2.fc20.src.rpm (In reply to comment #1) > 1. Please create a separate script (generate-sources.sh) to generate clean > tarball. It will make it easier for me to verify sources and should improve > maintaiability in future. > done > 2. Please describe the patch. Why is it needed? Is it upstreamable? Was it > submited upstream? > Yes, it's possibly upstreamable, but it needs some testing first. I've added comment to the spec file. > 3. According %pom_add_dep "commons-lang:commons-lang" > Is this a bug (missing dependency)? Is upstream aware of it? Please clarify. > That's fedora specific bug. Upstream uses different version of commons-cli which pulls in commons-lang for them. We have newer version of commons-cli which doesn't require commons-lang anymore. I've added comment to the spec file. > 4. Readme files should not be installed with javadoc package. > fixed > 5. Since you generated the tarball yourself it would make sense to name it > better. Current name is 1.1-jenkins-20120928-clean.tar.gz, something > standard like jenkins-commons-jelly-1.1.20120928-clean.tar.gz would probably > be better. done -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5R5ieQ1tUR&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review