[Bug 963213] Review Request: perl-HTTP-CookieJar - Minimalist HTTP user agent cookie jar

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=963213

--- Comment #1 from Petr Šabata <psabata@xxxxxxxxxx> ---
Missing build-time deps:
- Recommended: perl(File::Find), perl(HTTP::Request)*, perl(HTTP::Response)*,
perl(strict), perl(warnings)
* If you don't include those, you may safely drop some others that depend on
them, e.g. perl(URI).

None of your explicit run-requires are necessary and should be dropped.  RPM
detects all of them but Mozilla::PublicSuffix, which is optional.

PERL_INSTALL_ROOT could be substituted with DESTDIR.

Line 48 may be removed.

There's no need to ship dist.ini, META.json, perlcritic.rc, or tidyall.ini as
%doc.

I'll try to build it once our dependencies make it into Fedora.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iIaQZCfsPK&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]