Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=963197 --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 are usable. Ok. Source tar ball is original (SHA-256: b45b1effeaec9b20e8d024c77da2e403b0f89f0444a6c1981dc79aa25b80ced9). Ok. Summary verified from lib/Mozilla/PublicSuffix.pm. Ok. Description verified from lib/Mozilla/PublicSuffix.pm. Ok. TODO: Append trailing slash to the URL. HTTP URL has mandatory path part. License verified from LICENSE and lib/Mozilla/PublicSuffix.pm. Ok. No XS code, noArch BuildArch is Ok. TODO: Do not package dist.ini and perlcritic.rc files. There are no unique data usable for a user. TODO: Comment source of the overlay effective_tld_names.dat file (Source1). TODO: You can use plain `perl' command instead of `%{__perl}' macro. TODO: You can remove deleting empty directories from %install section. FIX: Build-require `perl(HTTP::Tiny)' (Build.PL:7). TODO: Build-require `perl(Tie::File)' (Build.PL:9). FIX: Build-require `perl(Exporter)' (lib/Mozilla/PublicSuffix.pm:6). FIX: Build-require `perl(File::Temp)' (t/00-compile.t:11). All tests pass. Ok. $ rpmlint perl-Mozilla-PublicSuffix.spec ../SRPMS/perl-Mozilla-PublicSuffix-0.1.13-1.20130515.fc20.src.rpm ../RPMS/noarch/perl-Mozilla-PublicSuffix-0.1.13-1.20130515.fc20.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. Package does not build in F20 (http://koji.fedoraproject.org/koji/taskinfo?taskID=5388055). Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Mozilla-PublicSuffix-0.1.13-1.20130515.fc20.noarch.rpm drwxr-xr-x 2 root root 0 May 16 15:02 /usr/share/doc/perl-Mozilla-PublicSuffix-0.1.13 -rw-r--r-- 1 root root 2493 Mar 6 22:22 /usr/share/doc/perl-Mozilla-PublicSuffix-0.1.13/Changes -rw-r--r-- 1 root root 1162 Mar 6 22:22 /usr/share/doc/perl-Mozilla-PublicSuffix-0.1.13/LICENSE -rw-r--r-- 1 root root 276 Mar 6 22:22 /usr/share/doc/perl-Mozilla-PublicSuffix-0.1.13/README -rw-r--r-- 1 root root 885 Mar 6 22:22 /usr/share/doc/perl-Mozilla-PublicSuffix-0.1.13/dist.ini -rw-r--r-- 1 root root 101920 May 16 14:41 /usr/share/doc/perl-Mozilla-PublicSuffix-0.1.13/effective_tld_names.dat -rw-r--r-- 1 root root 372 Mar 6 22:22 /usr/share/doc/perl-Mozilla-PublicSuffix-0.1.13/perlcritic.rc -rw-r--r-- 1 root root 2709 May 16 15:02 /usr/share/man/man3/Mozilla::PublicSuffix.3pm.gz drwxr-xr-x 2 root root 0 May 16 15:02 /usr/share/perl5/vendor_perl/Mozilla -rw-r--r-- 1 root root 91435 May 16 15:02 /usr/share/perl5/vendor_perl/Mozilla/PublicSuffix.pm File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Mozilla-PublicSuffix-0.1.13-1.20130515.fc20.noarch.rpm | sort | uniq -c 1 perl(Exporter) 1 perl(:MODULE_COMPAT_5.16.3) 1 perl(strict) 1 perl(URI::_idna) 1 perl(utf8) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Mozilla-PublicSuffix-0.1.13-1.20130515.fc20.noarch.rpm | sort | uniq -c 1 perl(Mozilla::PublicSuffix) = 0.1.13 1 perl-Mozilla-PublicSuffix = 0.1.13-1.20130515.fc20 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Mozilla-PublicSuffix-0.1.13-1.20130515.fc20.noarch.rpm Binary dependencies resolvable. Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' issues, consider fixing `TODO' items and provide new spec file. Resolution: Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=juxLR3ePnJ&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review