Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924310 --- Comment #8 from Wolfgang Ulbrich <chat-to-me@xxxxxxxxx> --- (In reply to comment #6) > > See sed comment, and whitespace issue above. > ============================================================================= > === > - update-desktop-database is invoked when required > Note: desktop file(s) in mate-document-viewer > See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache I did already run the review tool for my own, but why the review tool failed here? I use the update-desktop-database rpm scriplet because desktop file has a mime data entry. > > > (EPS) files. When supported by the document format, evince allows searching > > This is not evince, is it? Opps, thank you, i will change description. > > ============================================================================= > === > > files libs > > %{_libdir}/atril/3/backends/libpdfdocument.so > > %{_libdir}/atril/3/backends/pdfdocument.atril-backend > > %{_libdir}/atril/3/backends/libpsdocument.so > > %{_libdir}/atril/3/backends/psdocument.atril-backend > > %{_libdir}/atril/3/backends/libtiffdocument.so > > %{_libdir}/atril/3/backends/tiffdocument.atril-backend > > %{_libdir}/atril/3/backends/libcomicsdocument.so > > %{_libdir}/atril/3/backends/comicsdocument.atril-backend > > and later down: > > %files dvi > > %{_libdir}/atril/3/backends/libdvidocument.so* > > %{_libdir}/atril/3/backends/dvidocument.atril-backend > > > > %files djvu > > %{_libdir}/atril/3/backends/libdjvudocument.so > > %{_libdir}/atril/3/backends/djvudocument.atril-backend > > > > %files xps > > %{_libdir}/atril/3/backends/libxpsdocument.so > > %{_libdir}/atril/3/backends/xpsdocument.atril-backend > > Relating to what I asked in the previous comment: > There is no reason to separate dvi, djvu, and xps, but leave pdf, ps, and > tiff > integral. Please drop these subpackages, and simplify this to: > > %{_libdir}/atril/3/backends/lib*document.so > %{_libdir}/atril/3/backends/*document.atril-backend Agree. > > ============================================================================= > === > [!]: Package requires other packages for directories it uses. > > > %{_datadir}/icons/hicolor/*/apps/atril.* > Missing "Requires: hicolor-icon-them" Ohh, this is new for me, i will add the require. > > > %{_datadir}/MateConf/gsettings/atril.convert > > Missing "Requires: mate-conf" Mate-conf is obsolete. MATE is complete ported to gsettings started with 1.5.x package versions. After i removed mate-conf from my latest compiz packages i expected Dan Marchal (MATE Maintainer) will obsolete mate-conf too, like he did it with other obsolete MATE packages for f19. In fedora MATE started with 1.5.x versions, all of them didn't use mate-conf anymore, in result there is no user who have mate-conf settings to convert. > > ============================================================================= > === > [!]: Fully versioned dependency in subpackages, if present. > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mate- > document-viewer-libs > > Since -libs subpackage is not really separable from the main package, you > can go > ahead and add this. > Agree, will change it > ============================================================================= > === > [!]: Package uses nothing in %doc for runtime. > > %{_datadir}/doc/mate/atril/atril.html > > %{_datadir}/doc/mate/atril/atril_start_window.png > > These look like innocent documentation. You should include them with %doc. > otherwise, you end up with both mate/ and mate-document-viewer/ in > /usr/share/doc. So i can use %doc README COPYING NEWS AUTHORS atril.html atril_start_window.png ???? Or what do you suggest? Can you explain it more detail please? > > ============================================================================= > === > [!]: Package must own all directories that it creates. > > > %{_datadir}/mate/help/atril/ > $ yum provides /usr/share/mate > No Matches found > > Who owns %{_datadir}/mate/ and %{_datadir}/mate/atril/ ? %{_datadir}/mate/ should owned by mate-desktop, because this is the major and first package in MATE. Also the build order for MATE is mate-common, mate-doc-utils, mate-desktop and then the rest. But i noticed it isn't. http://pkgs.fedoraproject.org/cgit/mate-desktop.git/tree/mate-desktop.spec For me it looks like a issue with mate-desktop spec file. Owning this directory with an additional (m-d-v) package is the wrong way, imo. %{_datadir}/mate/atril/ doesn't exists, you mean %{_datadir}/mate/help/atril/ which is owned by m-d-v. > > > %{_libdir}/caja/extensions-2.0/libatril-properties-page.so > $ yum provides /usr/lib64/caja/ > No Matches found > $ yum provides /usr/lib/caja/ > No Matches found Caja is the internal name, the package name is mate-file-manager. http://pkgs.fedoraproject.org/cgit/mate-file-manager.git/tree/mate-file-manager.spec Maybe the same prob here, i think %{_libdir}/caja/extensions-2.0 should also own %{_libdir}/caja ??? > > > Rpmlint (installed packages) > ---------------------------- > mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libatrildocument.so.3.0.0 /lib64/libpangocairo-1.0.so.0 > mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libatrildocument.so.3.0.0 /lib64/libatk-1.0.so.0 > mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libatrildocument.so.3.0.0 /lib64/libpangoft2-1.0.so.0 > mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libatrildocument.so.3.0.0 /lib64/libpango-1.0.so.0 > mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libatrildocument.so.3.0.0 /lib64/libfreetype.so.6 > mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libatrildocument.so.3.0.0 /lib64/libfontconfig.so.1 > mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libatrilview.so.3.0.0 /lib64/libgmodule-2.0.so.0 > mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libatrilview.so.3.0.0 /lib64/libgthread-2.0.so.0 > mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libatrilview.so.3.0.0 /lib64/libpangocairo-1.0.so.0 > mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libatrilview.so.3.0.0 /lib64/libgdk_pixbuf-2.0.so.0 > mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libatrilview.so.3.0.0 /lib64/libpangoft2-1.0.so.0 > mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libatrilview.so.3.0.0 /lib64/libfreetype.so.6 > mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency I did try to fix this with # remove unused-direct-shlib-dependency sed -i -e 's! -shared ! -Wl,--as-needed\0!g' libtool Do you know a other solution? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=drxWNH43YP&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review