Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924310 --- Comment #7 from Wolfgang Ulbrich <chat-to-me@xxxxxxxxx> --- Thank you for revieving. (In reply to comment #5) > (Disclaimer: not an official review) > > %files dvi > > %{_libdir}/atril/3/backends/libdvidocument.so* > > > > %files djvu > > %{_libdir}/atril/3/backends/libdjvudocument.so > > > > %files xps > > %{_libdir}/atril/3/backends/libxpsdocument.so > > Why the "*" after libdvidocument.so, but not after the others? All of the > libraries are unversioned, so removing the "*" will give you a heads up if > upstream decides to version those libraries. yes, i will remove *. > > > %package libs > > %package dvi > > %package djvu > > %package xps > > Is there a reason to to separate the backends from the libs package? Think > of a user installing mate-document-viewer. Will they be able to view > $backendname files without installing the $backendname subpackage? > > I see this is a fork of evince, and evince uses the same splitup. However, > unless there is a good reason to do so, I think keeping everything in -libs > is saner. (Just look at texlive, which has almost 1000 subpackages). I did use the evince spec file as base if start building this package last year, but i agree there is no reason to do this for mate-document-viewer, and it is much user friendly. > > sed -i -e 's,Categories=MATE;GTK;Graphics;VectorGraphics;Viewer;,Categories=GTK;Graphics;VectorGraphics;Viewer;,g' data/atril.desktop.in.in data/atril.desktop.in.in > > sed -i -e '/GTK;Graphics;VectorGraphics;Viewer;/ a\OnlyShowIn=MATE;' data/atril.desktop.in.in > > Small comment explaining why this is needed. MATE hasn't a registred category in desktop-file-utils, only 'OnlyShowIn=MATE'. https://bugs.freedesktop.org/show_bug.cgi?id=44353#c2 But i fixed that already in upstream 1.6.0 version, here i started with the 1.5.x version. I agree that m-d-w can work as standalone without MATE desktop, so i won't add the 'OnlyShowIn=MATE entry. > > >%configure \ > > --disable-static \ > > --disable-scrollkeeper \ > > Whitespace issue. either use only tabs, or only spaces, but don't mix them > up. Of course, i will change it. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MOzXQCRRrG&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review