Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=952796 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #3 from Petr Pisar <ppisar@xxxxxxxxxx> --- Spec file changes: --- perl-Spreadsheet-XLSX.spec.old 2013-04-16 18:08:44.000000000 +0200 +++ perl-Spreadsheet-XLSX.spec 2013-05-09 17:07:03.000000000 +0200 @@ -3,7 +3,7 @@ Summary: Perl extension for reading Microsoft Excel 2007 files Name: perl-Spreadsheet-XLSX Version: 0.13 -Release: 1%{?dist} +Release: 2%{?dist} License: GPL+ or Artistic Group: Development/Libraries URL: http://search.cpan.org/dist/%{pkgname}/ @@ -12,6 +12,8 @@ Patch1: perl-Spreadsheet-XLSX-0.13-warnings.patch Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) BuildRequires: perl(Archive::Zip) >= 1.16, perl(Spreadsheet::ParseExcel) +BuildRequires: perl(ExtUtils::MakeMaker), perl(Data::Dumper), perl(Exporter) +BuildRequires: perl(Test::More) BuildArch: noarch BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) @@ -31,12 +33,12 @@ chmod 644 Changes README lib/Spreadsheet/{*,*/*}.pm %build -%{__perl} Makefile.PL INSTALLDIRS=vendor +perl Makefile.PL INSTALLDIRS=vendor make %{?_smp_mflags} %install rm -rf $RPM_BUILD_ROOT -make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT +make pure_install DESTDIR=$RPM_BUILD_ROOT find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} ';' find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null ';' @@ -49,12 +51,14 @@ rm -rf $RPM_BUILD_ROOT %files -%defattr(-,root,root,-) %doc Changes README %{perl_vendorlib}/Spreadsheet/ %{_mandir}/man3/*.3pm* %changelog +* Thu May 09 2013 Robert Scheck <robert@xxxxxxxxxxxxxxxxx> 0.13-2 +- Changes to match with Fedora Packaging Guidelines (#952796) + * Tue Apr 16 2013 Robert Scheck <robert@xxxxxxxxxxxxxxxxx> 0.13-1 - Upgrade to 0.13 - Initial spec file for Fedora and Red Hat Enterprise Linux > FIX: Build-require `perl(ExtUtils::MakeMaker)' (Makefile.PL:2). > FIX: Build-require `perl(Data::Dumper)' for running tests > (lib/Spreadsheet/XLSX.pm:13). > FIX: Build-require `perl(Exporter)' for running tests > (lib/Spreadsheet/XLSX/Utility2007.pm:12). > FIX: Build-require `perl(Test::More)' for running tests > (t/2_____with_chart.t:1). +BuildRequires: perl(ExtUtils::MakeMaker), perl(Data::Dumper), perl(Exporter) +BuildRequires: perl(Test::More) Ok. > TODO: You can use plain `perl' instead of macro `%{__perl}'. -%{__perl} Makefile.PL INSTALLDIRS=vendor +perl Makefile.PL INSTALLDIRS=vendor Ok. > TODO: You can replace `PERL_INSTALL_ROOT' with `DESTDIR' argument in > %install section. -make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT +make pure_install DESTDIR=$RPM_BUILD_ROOT Ok. > TODO: You can remove explicit %defattr definition in %files sectinos. -%defattr(-,root,root,-) Ok. $ rpmlint perl-Spreadsheet-XLSX.spec ../SRPMS/perl-Spreadsheet-XLSX-0.13-2.fc20.src.rpm ../RPMS/noarch/perl-Spreadsheet-XLSX-0.13-2.fc20.noarch.rpm perl-Spreadsheet-XLSX.src: W: spelling-error %description -l en_US ParseExcel -> Parse Excel, Parse-excel, Paracelsus perl-Spreadsheet-XLSX.src: W: spelling-error %description -l en_US interoperability -> interchangeability, invulnerability, inseparability perl-Spreadsheet-XLSX.noarch: W: spelling-error %description -l en_US ParseExcel -> Parse Excel, Parse-excel, Paracelsus perl-Spreadsheet-XLSX.noarch: W: spelling-error %description -l en_US interoperability -> interchangeability, invulnerability, inseparability 2 packages and 1 specfiles checked; 0 errors, 4 warnings. rpmlint is Ok. > FIX: Declare all the build-time dependencies. Package builds in F20 (perl-Spreadsheet-XLSX-0.13-2.fc20.src.rpm). Ok. Package is good. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4hCT0eu6dw&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review