Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960252 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #4 from Petr Pisar <ppisar@xxxxxxxxxx> --- Spec file changes: --- perl-File-Touch.spec.old 2013-05-09 15:51:15.000000000 +0200 +++ perl-File-Touch.spec 2013-05-09 16:46:24.000000000 +0200 @@ -2,14 +2,13 @@ Summary: Update access, modification timestamps, creating nonexistent files Version: 0.08 Release: 2%{?dist} -License: ASL 2.0 +License: GPL+ or Artistic Group: Development/Libraries URL: http://search.cpan.org/dist/File-Touch BuildArch: noarch Source: http://search.cpan.org/CPAN/authors/id/N/NW/NWETTERS/File-Touch-%{version}.tar.gz BuildRequires: perl(ExtUtils::MakeMaker) BuildRequires: perl -BuildRequires: perl(base) BuildRequires: perl(Carp) BuildRequires: perl(Exporter) BuildRequires: perl(strict) @@ -42,8 +41,7 @@ %changelog * Thu May 9 2013 Andrea Veri <averi@xxxxxxxxxxxxxxxxx> - 0.08-2 -- Change the license to ASL 2.0. -- Fix Source0 to point to UpstreamName-%{version}. +- Fix Source0 to point to UpstreamName-%%{version}. - Add the missing Build Depends. * Mon May 6 2013 Andrea Veri <averi@xxxxxxxxxxxxxxxxx> - 0.08-1 > TODO: Correct summary spelling (timestamps → time stamps). Not addressed. > TODO: Rephrase description (The following Perl module allows you to → This Perl module allows you to). Nothing follows after the sentence. Not addressed. > FIX: Correct license tag (Touch.pm states (GPL+ or Artistic)). -License: ASL 2.0 +License: GPL+ or Artistic Ok. > TODO: Build-require `perl(IO::File)' (Touch.pm:11). > TODO: Build-require `perl(File::stat)' (Touch.pm:12). > TODO: Build-require `perl(Fcntl)' (Touch.pm:13). Not addressed. Please note that this insufficiency can cause build failures in the future. > FIX: Do not build-require `perl(base)'. It's used nowhere. -BuildRequires: perl(base) Ok. > TODO: You can use simple `perl' instead of `%{__perl}' macro. Not addressed. > FIX: Escape the per-cent character in the changelog with another per-cent character. -- Fix Source0 to point to UpstreamName-%{version}. +- Fix Source0 to point to UpstreamName-%%{version}. Ok. $ rpmlint perl-File-Touch.spec ../SRPMS/perl-File-Touch-0.08-2.fc20.src.rpm ../RPMS/noarch/perl-File-Touch-0.08-2.fc20.noarch.rpm perl-File-Touch.src: W: spelling-error Summary(en_US) timestamps -> time stamps, time-stamps, times tamps perl-File-Touch.src: W: spelling-error %description -l en_US timestamps -> time stamps, time-stamps, times tamps perl-File-Touch.noarch: W: spelling-error Summary(en_US) timestamps -> time stamps, time-stamps, times tamps perl-File-Touch.noarch: W: spelling-error %description -l en_US timestamps -> time stamps, time-stamps, times tamps 2 packages and 1 specfiles checked; 0 errors, 4 warnings. TODO: Correct the spelling. Package builds in F20 (http://koji.fedoraproject.org/koji/taskinfo?taskID=5360101). Ok. Please consider fixing the `TODO' items before building the package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=t9W1l2CtcW&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review