Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=961141 --- Comment #6 from Sergio Monteiro Basto <sergio@xxxxxxxxxx> --- (In reply to comment #5) > for comment #3 > * The duplicate file revealed a far bigger issue -- find_lang --with-man > only handle single man-page -- replaced with modified logic in our .spec Should keep comment the original find_lang --with-man, for when find_lang works as we expect. > * Updated one $RPM_BUILD_ROOT to %{buildroot} so .spec is consistent OK > * Updated changelog to have consistent version not complete yet need : -* Thu May 9 2013 Oron Peled <oron@xxxxxxxxxxxx> - 9.20120909-1.fc18 +* Thu May 9 2013 Oron Peled <oron@xxxxxxxxxxxx> - 9.20120909-1 > * About "dpkg-devel": > - Yes it is needed. It contains all the tools used by the debhelper > wrappers like deb-substvars, deb-shlibs, etc. > - The dpkg RPM split mirror the Debian package split -- I think w > should stay that way. > - Is there a standard way to declare -- "this is an rpmlint exception?" We need dpkg-devel before finish this review, I think , like others that depend on this one. Also you used tabs instead spaces , with vim we should use set expandtab by default , if you use vim to edit you can do: :set expandtab :retab to fix - s:%{buildroot}:: - s:\(.*/man/\([^/_]\+\).*/man[a-z0-9]\+/[^.]\+\.[a-z0-9].*\):%lang(\2) \1*: - s:^\([^%].*\):: - s:%lang(C) :: - /^$/d - ' > debhelper-mans.lang + s:%{buildroot}:: + s:\(.*/man/\([^/_]\+\).*/man[a-z0-9]\+/[^.]\+\.[a-z0-9].*\):%lang(\2) \1*: + s:^\([^%].*\):: + s:%lang(C) :: + /^$/d + ' > debhelper-mans.lang -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=faTUPAG4M6&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review