[Bug 919265] Review Request: Bijiben - Note taking app

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=919265

--- Comment #23 from Mathieu Bridon <bochecha@xxxxxxxxxxxxxxxxx> ---
(In reply to comment #22)
> 5)
> /usr/share/bijiben/icons
> /usr/share/bijiben/icons/hicolor
> /usr/share/bijiben/icons/hicolor/16x16
> /usr/share/bijiben/icons/hicolor/16x16/actions
> /usr/share/bijiben/icons/hicolor/16x16/actions/note.png
> /usr/share/bijiben/icons/hicolor/24x24
> /usr/share/bijiben/icons/hicolor/24x24/actions
> /usr/share/bijiben/icons/hicolor/24x24/actions/note.png
> /usr/share/bijiben/icons/hicolor/48x48
> /usr/share/bijiben/icons/hicolor/48x48/actions
> /usr/share/bijiben/icons/hicolor/48x48/actions/note.png
> /usr/share/bijiben/icons/hicolor/scalable
> /usr/share/bijiben/icons/hicolor/scalable/actions
> /usr/share/bijiben/icons/hicolor/scalable/actions/link.svg
> /usr/share/bijiben/icons/hicolor/scalable/actions/note.svg
> 
> 
> Are these supposed to get installed in /usr/share/bijiben ? The directory
> layout looks like they should have gone to /usr/share/icons/hicolor instead.

I don't think so, or at least, they should probably be renamed then, to avoid
conflicts with other packages. (these names are too generic for a shared
location)

But is there something in the guidelines that forbids installing icons here?
That seems perfectly fine to me.

(I'm asking because I thought it was fine when I did the initial review, and
I'd be happy to learn if I was wrong :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SZst7eklAX&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]