Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919265 --- Comment #22 from Kalev Lember <kalevlember@xxxxxxxxx> --- A few comments / questions about this package: 1) The name and summary in the spec file should match up with the name and summary in the review ticket (and also with the name and summary in the SCM request that you are going to file soon). Right now the ticket here has: Review Request: Bijiben - Note taking app ... and the spec file: Name: bijiben Summary: Simple Note Viewer Can you update the ticket here with the lowercase 'bijiben' name and sync up the descriptions? The scripts for creating new git repos check these. 2) > autoreconf -i -f The autoreconf call seems unneeded now that you are no longer patching the build system. 3) > %exclude %{_libdir}/%{name}/libgd.la Shouldn't be needed any more now that the package is no longer installing the libgd shared library. 4) > %files > %doc NEWS AUTHORS COPYING ChangeLog NEWS README > %files -f %{name}.lang Two issues here: you are repeating the %files section and the NEWS file is listed twice. It should read: %files -f %{name}.lang %doc AUTHORS COPYING ChangeLog NEWS README 5) /usr/share/bijiben/icons /usr/share/bijiben/icons/hicolor /usr/share/bijiben/icons/hicolor/16x16 /usr/share/bijiben/icons/hicolor/16x16/actions /usr/share/bijiben/icons/hicolor/16x16/actions/note.png /usr/share/bijiben/icons/hicolor/24x24 /usr/share/bijiben/icons/hicolor/24x24/actions /usr/share/bijiben/icons/hicolor/24x24/actions/note.png /usr/share/bijiben/icons/hicolor/48x48 /usr/share/bijiben/icons/hicolor/48x48/actions /usr/share/bijiben/icons/hicolor/48x48/actions/note.png /usr/share/bijiben/icons/hicolor/scalable /usr/share/bijiben/icons/hicolor/scalable/actions /usr/share/bijiben/icons/hicolor/scalable/actions/link.svg /usr/share/bijiben/icons/hicolor/scalable/actions/note.svg Are these supposed to get installed in /usr/share/bijiben ? The directory layout looks like they should have gone to /usr/share/icons/hicolor instead. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XInPP4jB9g&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review