Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960401 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #3 from Petr Pisar <ppisar@xxxxxxxxxx> --- Spec file changes: --- xssstate.spec.old 2013-05-07 09:30:04.000000000 +0200 +++ xssstate.spec 2013-05-07 17:03:43.373000000 +0200 @@ -1,10 +1,11 @@ Name: xssstate Version: 1.0 Release: 1%{?dist} -Summary: A simple tool to retrieve the X screensaver state +Summary: A simple tool to retrieve the X screen saver state License: MIT URL: http://tools.suckless.org/%{name} Source0: http://dl.suckless.org/tools/%{name}-%{version}.tar.gz +Patch0: %{name}-1.0-format.patch BuildRequires: libXScrnSaver-devel %description @@ -12,11 +13,13 @@ %prep %setup -q +%patch0 -p1 sed -e 's|PREFIX = /usr/local|PREFIX = %{_prefix}|' \ -e 's|LIBS = -L/usr/lib -lc -lX11 -lXss|LIBS = -L%{_libdir} -lc -lX11 -lXss|' \ -e 's|CFLAGS = -g -std=c99 -pedantic -Wall -O0 ${INCS} ${CPPFLAGS}|CFLAGS = %{optflags} ${INCS} ${CPPFLAGS}|' \ -i config.mk sed -i 's|^\t@|\t|' Makefile +chmod -x xsidle.sh %build make %{?_smp_mflags} > TODO: There are two bugs in the source: +Patch0: %{name}-1.0-format.patch And I saw that the patch was good. Ok. > TODO: Consider spelling `screensaver' with a hyphen or a space. -Summary: A simple tool to retrieve the X screensaver state +Summary: A simple tool to retrieve the X screen saver state Ok. > FIX: Do not scan documentation for dependencies (/bin/sh). +chmod -x xsidle.sh Ok. $ rpmlint xssstate.spec ../SRPMS/xssstate-1.0-1.fc20.src.rpm ../RPMS/x86_64/xssstate-* 3 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/x86_64/xssstate-1.0-1.fc20.x86_64.rpm -rwxr-xr-x 1 root root 11368 May 7 17:08 /usr/bin/xssstate drwxr-xr-x 2 root root 0 May 7 17:08 /usr/share/doc/xssstate-1.0 -rw-r--r-- 1 root root 1138 Feb 1 13:10 /usr/share/doc/xssstate-1.0/LICENSE -rw-r--r-- 1 root root 784 Feb 1 13:10 /usr/share/doc/xssstate-1.0/README -rw-r--r-- 1 root root 360 Feb 1 13:10 /usr/share/doc/xssstate-1.0/xsidle.sh -rw-r--r-- 1 root root 443 May 7 17:08 /usr/share/man/man1/xssstate.1.gz File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/x86_64/xssstate-1.0-1.fc20.x86_64.rpm | sort libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libX11.so.6()(64bit) libXss.so.1()(64bit) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 rtld(GNU_HASH) Binary requires are Ok. Package builds in F20 (http://koji.fedoraproject.org/koji/taskinfo?taskID=5340105). Ok. Package is good. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=R50Ur9JFXF&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review