Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960401 --- Comment #2 from Petr Šabata <psabata@xxxxxxxxxx> --- (In reply to comment #1) > URL and Source0 are usable. Ok. > Source tar ball is original (SHA-256: > e5b60a6e48133944ef6f3c2e0b7bd40e0d84d2d97ed9790c85c382bc1998bf04). Ok. > License is Ok. > Summary and description is good. > > TODO: There are two bugs in the source: > > printf("%ld\n", info->til_or_since); > printf("%ld\n", info->idle); > > Both variables are of type unsigned long, but the formatting strings are > %ld. See <X11/extensions/scrnsaver.h> for XScreenSaverInfo type definitions. Patched to %lu and submitted upstream. > $ rpmlint xssstate.spec ../SRPMS/xssstate-1.0-1.fc20.src.rpm > ../RPMS/x86_64/xssstate-* > xssstate.src: W: spelling-error Summary(en_US) screensaver -> screen saver, > screen-saver, screens aver > xssstate.src: W: spelling-error %description -l en_US screensaver -> screen > saver, screen-saver, screens aver > xssstate.x86_64: W: spelling-error Summary(en_US) screensaver -> screen > saver, screen-saver, screens aver > xssstate.x86_64: W: spelling-error %description -l en_US screensaver -> > screen saver, screen-saver, screens aver > 3 packages and 1 specfiles checked; 0 errors, 4 warnings. > > TODO: Consider spelling `screensaver' with a hyphen or a space. Switched to "screen saver" to be in line with other packages (e.g. xscreensaver). > $ rpm -q -lv -p ../RPMS/x86_64/xssstate-1.0-1.fc20.x86_64.rpm > -rwxr-xr-x 1 root root 11368 May 7 12:49 > /usr/bin/xssstate > drwxr-xr-x 2 root root 0 May 7 12:49 > /usr/share/doc/xssstate-1.0 > -rw-r--r-- 1 root root 1138 Feb 1 13:10 > /usr/share/doc/xssstate-1.0/LICENSE > -rw-r--r-- 1 root root 784 Feb 1 13:10 > /usr/share/doc/xssstate-1.0/README > -rwxr-xr-x 1 root root 360 Feb 1 13:10 > /usr/share/doc/xssstate-1.0/xsidle.sh > -rw-r--r-- 1 root root 443 May 7 12:49 > /usr/share/man/man1/xssstate.1.gz > File layout and permissions are Ok. > > $ rpm -q --requires -p ../RPMS/x86_64/xssstate-1.0-1.fc20.x86_64.rpm | sort > /bin/sh > libc.so.6()(64bit) > libc.so.6(GLIBC_2.2.5)(64bit) > libc.so.6(GLIBC_2.3.4)(64bit) > libX11.so.6()(64bit) > libXss.so.1()(64bit) > rpmlib(CompressedFileNames) <= 3.0.4-1 > rpmlib(FileDigests) <= 4.6.0-1 > rpmlib(PayloadFilesHavePrefix) <= 4.0-1 > rpmlib(PayloadIsXz) <= 5.2-1 > rtld(GNU_HASH) > > FIX: Do not scan documentation for dependencies (/bin/sh). Done. > $ rpm -q --provides -p ../RPMS/x86_64/xssstate-1.0-1.fc20.x86_64.rpm | sort > xssstate = 1.0-1.fc20 > xssstate(x86-64) = 1.0-1.fc20 > Binary provides are Ok. > > $ resolvedeps rawhide ../RPMS/x86_64/xssstate-1.0-1.fc20.x86_64.rpm > Binary dependencies resolvable. Ok. > > Package builds in F20 > (http://koji.fedoraproject.org/koji/taskinfo?taskID=5338920). Ok. > > Otherwise the package is line with Fedora packaging guidelines. > > Please correct all `FIX' issues, consider fixing `TODO' items, and provide > new spec file. > > Resolution: Package NOT approved. The original links now point to the updated package. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sszC2kv9vL&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review