[Bug 958881] Review Request: ibus-cangjie - IBus engine to input Cangjie and Quick

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=958881

--- Comment #3 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:

+ koji scratch build for f20 ->
http://koji.fedoraproject.org/koji/taskinfo?taskID=5333725

+ rpmlint on rpms gave
ibus-cangjie.noarch: W: no-manual-page-for-binary ibus-setup-cangjie
ibus-cangjie.src:55: E: hardcoded-library-path in %{_prefix}/lib/%{name}
2 packages and 0 specfiles checked; 1 errors, 1 warnings.


+ Source verified with upstream as
http://ibus-cangjie.opensource.hk/downloads/ibus-cangjie/ibus-cangjie-1.0.tar.xz
:
  CHECKSUM(SHA256) this package     :
b337004848513edc035bae7babc5ec4fe25d9fcff463001fcebfbe7467a16764
  CHECKSUM(SHA256) upstream package :
b337004848513edc035bae7babc5ec4fe25d9fcff463001fcebfbe7467a16764



Suggestions:
1) Desktop files should be installed as per given in 
https://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage

2) Good to add some comment in spec for rpmlint error of hardcoded-library-path

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YwcFsVK7al&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]