[Bug 958881] Review Request: ibus-cangjie - IBus engine to input Cangjie and Quick

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=958881

--- Comment #2 from Mathieu Bridon <bochecha@xxxxxxxxxxxxxxxxx> ---
Thanks Adam for looking at it.

(In reply to comment #1)
> Not assigned to me, but I gave it a quick once-over anyway, I don't see
> anything at all wrong, passes all requirements for me. It might be useful to
> explain the use of %_prefix/lib - I'm sure there's a good reason for it, but
> it's the kind of thing that gets flagged (rpmlint complains).

This package is noarch, and as such is exempt from multilib, so %{_prefix}/lib
is allowed as per:
https://fedoraproject.org/wiki/Packaging:Guidelines#Multilib_Exempt_Locations

Maybe I could add a comment in the spec file?

> Other than
> that, looks good. I did a successful Rawhide scratch build, but F19 fails
> because python3-cangjie is not yet available; the update is still in
> updates-testing, I see.

I could add a buildroot override if it helps. I'll need one anyway to build it
once approved, so I don't mind creating it a bit in advance. :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1UZevah9ti&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]