Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957436 Petr Šabata <psabata@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841 (FE-NEEDSPONSOR) | Flags|fedora-review? | Flags| |fedora-review+ --- Comment #4 from Petr Šabata <psabata@xxxxxxxxxx> --- (In reply to comment #3) > (In reply to comment #2) > > 1. Summary -- you don't have to capitalize every word; in fact, you > > shouldn't. Change it to something like "A user-friendly text file viewer". > > This is a copy and paste error, fixed. Ack. > > 2. %description -- substitute "lookat" with %{name}. > > Well I never do this in my packages' %description section, I think it's a > bit ugly... > > Is it a MUST or SHOULD? There's no hard rule for this but it's commonly discouraged to repeat the package name in summary and description. Using %{name} there is pretty much a matter of style. If you really don't want it, the don't change anything. Not a blocker. > > 3. Build-time dependencies: > > - glibc-devel is not used at all, remove it, > > - the same applies to libtool, > > - and pkgconfig too. > > Fixed. Ack. > > 4. License -- FSF address stated in COPYING and all of the source files > > (*.[ch]) is outdated. Please, ask upstream to fix this in the next release. > > The current license is available here: > > https://www.gnu.org/licenses/old-licenses/gpl-2.0.txt > > Waiting upstream. Ok. Not a blocker. > > 5. Upstream build scripts don't provide support for aarch64. Please, run > > 'autoreconf -fiv' in the beginning of your %build section (or in %prep if > > you prefer) to fix this. > > Fixed, but there are no docs around currently. Where can I get detailed > information to prevent things happen again? There are no guidelines for this yet, I believe, however this was discussed on Fedora development list in February and March this year. I'd give you links but lists.fedoraproject.org seems to be down at the moment. Briefly: check if the build files contain 'aarch64'; if they don't, they need to be regenerated with autoconf-2.69+ > > 6. There's no need to define prefix, sysconfdir, or mandir. Just call plain > > '%configure' and watch the magic happen. > > Fixed. Ack. --- Alright, approving. I also see Ken has sponsored you already (bug #947071#11), hence I'm removing the NEEDSPONSOR depedency. Please, do that in the rest of your reviews. You may now submit the SCM request. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=V1h4WFwiso&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review