[Bug 957436] Review Request: lookat - User-Friendly Text File Viewer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=957436

--- Comment #3 from Christopher Meng <cickumqt@xxxxxxxxx> ---
(In reply to comment #2)
> 1. Summary -- you don't have to capitalize every word; in fact, you
> shouldn't.  Change it to something like "A user-friendly text file viewer".

This is a copy and paste error, fixed.

> 2. %description -- substitute "lookat" with %{name}.

Well I never do this in my packages' %description section, I think it's a bit
ugly...

Is it a MUST or SHOULD?

> 3. Build-time dependencies:
>   - glibc-devel is not used at all, remove it,
>   - the same applies to libtool,
>   - and pkgconfig too.

Fixed.

> 4. License -- FSF address stated in COPYING and all of the source files
> (*.[ch]) is outdated.  Please, ask upstream to fix this in the next release.
> The current license is available here:
> https://www.gnu.org/licenses/old-licenses/gpl-2.0.txt

Waiting upstream.

> 5. Upstream build scripts don't provide support for aarch64.  Please, run
> 'autoreconf -fiv' in the beginning of your %build section (or in %prep if
> you prefer) to fix this.

Fixed, but there are no docs around currently. Where can I get detailed
information to prevent things happen again?

> 6. There's no need to define prefix, sysconfdir, or mandir.  Just call plain
> '%configure' and watch the magic happen.

Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2YYyA9TUDl&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]