Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=917365 --- Comment #11 from Truong Anh Tuan <tuanta@xxxxxxxxxxxxxxx> --- (In reply to comment #10) > Thanks for the update. > > (In reply to comment #9) > > > > /bin/sh: pyside-lupdate: command not found > > > make[2]: *** [config-gui/CMakeFiles/translations] Error 127 > > > > > > But I could work around this by installing pyside-tools. > > > > This has been updated to BuildRequires > > Well, still not there in 0.3-3. Maybe you could adjust it at initial import. My fault :( I updated this. > > > Rpmlint > > > Could you please recheck the new version for me. > > Here is the result of rpmlint against the new version: > > Rpmlint > ------- > Checking: ibus-bogo-0.3-3.fc20.noarch.rpm > ibus-bogo.noarch: E: non-executable-script > /usr/share/ibus-bogo/config-gui/controller.py 0644L /usr/bin/env > 1 packages and 0 specfiles checked; 1 errors, 0 warnings. > > I guess you can safely remove the shebang line "#!/usr/bin/env > python3" of controller.py, as ibus-bogo-settings script runs the > script with python2. I updated this as well. Please see new versions at: Spec URL: http://tuanta.fedorapeople.org/ibus-bogo/ibus-bogo.spec SRPM URL: http://tuanta.fedorapeople.org/ibus-bogo/ibus-bogo-0.3-4.fc18.src.rpm > Anyway, looks better and I'd approve the package. Thanks. You done this or not? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4SXfMItzqP&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review