Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=917365 Daiki Ueno <dueno@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #10 from Daiki Ueno <dueno@xxxxxxxxxx> --- Thanks for the update. (In reply to comment #9) > > /bin/sh: pyside-lupdate: command not found > > make[2]: *** [config-gui/CMakeFiles/translations] Error 127 > > > > But I could work around this by installing pyside-tools. > > This has been updated to BuildRequires Well, still not there in 0.3-3. Maybe you could adjust it at initial import. > > SyntaxError: Non-ASCII character '\xe1' in file > > I will check with upstream developers. > > Since this issue does not effect to main program (the Vietnamese keyboard > typing) but just the settings module, can we still push the package to > Fedora repos? (while checking with them) Sure. > > [!]: Final provides and requires are sane (see attachments). > > Can you explain more what I need to do here? My mistake, sorry. I first thought that the settings app needs qt4 rather than qt3, but it seems to work with both. > > [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. > > If this note is mandatory, I will work with upstream developers to have them. This is a SHOULD item, so I think it is fine to ignore at the moment. > > Rpmlint > Could you please recheck the new version for me. Here is the result of rpmlint against the new version: Rpmlint ------- Checking: ibus-bogo-0.3-3.fc20.noarch.rpm ibus-bogo.noarch: E: non-executable-script /usr/share/ibus-bogo/config-gui/controller.py 0644L /usr/bin/env 1 packages and 0 specfiles checked; 1 errors, 0 warnings. I guess you can safely remove the shebang line "#!/usr/bin/env python3" of controller.py, as ibus-bogo-settings script runs the script with python2. Anyway, looks better and I'd approve the package. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=y3kT9w7uK4&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review