[Bug 928841] Review Request: drupal7-theme-zen - Zen is a powerful, yet simple, HTML5 starting theme

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=928841

--- Comment #7 from Jared Smith <jsmith.fedora@xxxxxxxxx> ---
(In reply to comment #6)
> The license files are added to the downloads by the Drupal build process. 
> Project owners do not add these themselves.  The only way for the project
> owners to fix this is to push out a new version/release.

That's fine -- I'm willing to let it go for now, as long as upstream knows
about the issue and will address it in a future release.  It's not a critical
issue, but something that should be addressed.

> > [ BAD ] MUST: The License field in the package spec file must match the
> > actual
> > license. 
> > 
> > I noticed that zen/js/html5.js and zen/js/html5-respond.js are licensed as
> > both MIT and GPLv2, but the spec file only lists the GPL license
> 
> Good catch!!!  Question: Do you know if license files for each need to be
> included?

I wouldn't worry about including a license file for a one-file Javascript
library.  (And, just for the sake of completeness -- I don't think we need to
package these two javascript libraries separately, at least until the
Javascript packaging guidelines are ratified by the FPC.)

I'd just make sure that the license line in the .spec file mentions the other
licenses, and maybe even put a comment in there that the theme itself is GPL,
but the two Javascript libraries are dual-licensed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wnMc8HVfyC&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]