Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=928841 --- Comment #6 from Shawn Iwinski <shawn.iwinski@xxxxxxxxx> --- (In reply to comment #5) > [ O K ] MUST: rpmlint must be run on every package. The output should be > posted > in the review. > > [jsmith@hockey zen]$ rpmlint drupal7-theme-zen.spec > drupal7-theme-zen-5.1-1.fc18.src.rpm > /home/jsmith/rpmbuild/RPMS/noarch/drupal7-theme-zen-5.1-1.fc18.noarch.rpm > drupal7-theme-zen.noarch: E: incorrect-fsf-address > /usr/share/drupal7/themes/zen/STARTERKIT/sass-extensions/zen-grids/LICENSE. > txt > 2 packages and 1 specfiles checked; 1 errors, 0 warnings. > > Notice that the error is about the incorrect address for the FSF in the > license file -- you should work with upstream to get that fixed. The license files are added to the downloads by the Drupal build process. Project owners do not add these themselves. The only way for the project owners to fix this is to push out a new version/release. For this rpmlint "error" packagers usually only need to notify upstream of the "issue". However, we could fix this 2 ways: 1) Include a separate LICENSE.txt file as an RPM source 2) Wait until version 5.2 is released by upstream (this would cause the Drupal build process to add the new license) > [ BAD ] MUST: The License field in the package spec file must match the > actual > license. > > I noticed that zen/js/html5.js and zen/js/html5-respond.js are licensed as > both MIT and GPLv2, but the spec file only lists the GPL license Good catch!!! Question: Do you know if license files for each need to be included? > Also, I was wondering if there was any precedence for putting the word > "theme" in the package name. The other Drupal modules simply have the name > of the project -- basically the part after drupal.org/project/ in the module > URL. I was just following the naming convention of "drupal7-theme-adaptivetheme" and "drupal7-theme-ninesixty" (the only other themes I know about in the repo). However, I would much prefer taking "theme" out of the package name! All Drupal machine names are guaranteed to be unique and modules and themes both share the same machine name namespace. I wish there was a "drupal-devel" mailing list to ask ;) Perhaps for this drupal7 theme we could stick with the drupal7-theme-zen pkg name to conform but also virtually provide drupal7-zen and then update the drupal8 packaging guidelines to specifically call out removing the "theme" part of the name? I will clear the needinfo flag when I fix the license issue. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jAM4Hxe2WM&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review