Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=750394 --- Comment #39 from Kapil Arya <kapil@xxxxxxxxxxx> --- Hi Orion, Thanks for the quick response. I am putting my responses inline. Also, could you tell me how did you generate this report so that I can do it locally and fix issues before sending it to you? Thanks, Kapil > Issues: > ======= > - Sources used to build the package match the upstream source, as provided in > the spec URL. > Note: Upstream MD5sum check error, diff is in > /export/home/orion/redhat/dmtcp-1.3.0/750394-dmtcp/diff.txt > See: http://fedoraproject.org/wiki/Packaging/SourceURL That was a stupid mistake on my end. Fixed. > - All build dependencies are listed in BuildRequires, except for any that are > listed in the exceptions section of Packaging Guidelines. > Note: These BR are not needed: gcc gcc-c++ glibc-devel > See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 Fixed~ > - No Requires: %{name}%{?_isa} = %{version}-%{release} in libmtcp , > libmtcp-devel , libdmtcpaware , libdmtcpaware-devel , libdmtcpaware-doc > , > libdmtcpaware-static - you must specify "%{version}-%{release}" Here is slight confusion. libmtcp provides a shared library that is needed by the main package. libmtcp does not depend on the main package itself. How should I fix the "Requires" section for libmtcp in this case? > Minor: > > - I would suggest a blank line between changelog entries. > - Drop %defattr() > - Drop BuildRoot > - Drop %clean Fixed. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tyqiDBKD9a&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review