Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=750394 --- Comment #38 from Orion Poplawski <orion@xxxxxxxxxxxxx> --- Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /export/home/orion/redhat/dmtcp-1.3.0/750394-dmtcp/diff.txt See: http://fedoraproject.org/wiki/Packaging/SourceURL - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: gcc gcc-c++ glibc-devel See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 - No Requires: %{name}%{?_isa} = %{version}-%{release} in libmtcp , libmtcp-devel , libdmtcpaware , libdmtcpaware-devel , libdmtcpaware-doc , libdmtcpaware-static - you must specify "%{version}-%{release}" Minor: - I would suggest a blank line between changelog entries. - Drop %defattr() - Drop BuildRoot - Drop %clean ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Static libraries in -static subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [!]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [!]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libmtcp , libmtcp-devel , libdmtcpaware , libdmtcpaware-devel , libdmtcpaware-doc , libdmtcpaware-static [x]: Package complies to the Packaging Guidelines [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "LGPL (v2.1 or later)", "LGPL (v3 or later)", "LGPL (v2.1 or later) (with incorrect FSF address)", "Unknown or generated". 4 files have unknown license. Detailed output of licensecheck in /export/home/orion/redhat/dmtcp-1.3.0/750394-dmtcp/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [-]: Large documentation must go in a -doc subpackage. Note: Documentation size is 30720 bytes in 2 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Buildroot is not present Note: Buildroot: present but not needed [!]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint (installed packages) ---------------------------- dmtcpaware libdmtcpaware-docl libmtcp-devel libmtcp libdmtcpaware-static dmtcp lib libdmtcpaware-devel.x86_64: W: spelling-error %description -l en_US checkpointing -> check pointing, check-pointing, checkpoint libdmtcpaware-devel.x86_64: W: spelling-error %description -l en_US multi -> mulch, mufti libdmtcpaware-devel.x86_64: W: spelling-error %description -l en_US cscope -> scope, c scope, cs cope libdmtcpaware-devel.x86_64: W: spelling-error %description -l en_US emacs -> Emacs, macs, maces libdmtcpaware-devel.x86_64: W: spelling-error %description -l en_US dmtcp -> Dmitri libdmtcpaware-devel.x86_64: W: no-documentation libmtcp-devel.x86_64: W: no-documentation libmtcp.x86_64: W: spelling-error Summary(en_US) checkpointer -> check pointer, check-pointer, checkpoint er libmtcp.x86_64: W: no-documentation libdmtcpaware-static.x86_64: W: spelling-error %description -l en_US dmtcpaware -> Delaware libdmtcpaware-static.x86_64: W: no-documentation dmtcp.x86_64: W: spelling-error %description -l en_US checkpointing -> check pointing, check-pointing, checkpoint dmtcp.x86_64: W: spelling-error %description -l en_US multi -> mulch, mufti dmtcp.x86_64: W: spelling-error %description -l en_US cscope -> scope, c scope, cs cope dmtcp.x86_64: W: spelling-error %description -l en_US emacs -> Emacs, macs, maces dmtcp.x86_64: W: ldd-failed /usr/bin/mtcp_restart dmtcp.x86_64: E: statically-linked-binary /usr/bin/mtcp_restart libdmtcpaware.x86_64: W: spelling-error %description -l en_US checkpointing -> check pointing, check-pointing, checkpoint libdmtcpaware.x86_64: W: spelling-error %description -l en_US multi -> mulch, mufti libdmtcpaware.x86_64: W: spelling-error %description -l en_US cscope -> scope, c scope, cs cope libdmtcpaware.x86_64: W: spelling-error %description -l en_US emacs -> Emacs, macs, maces libdmtcpaware.x86_64: W: spelling-error %description -l en_US checkpointed -> check pointed, check-pointed, checkpoint ed libdmtcpaware.x86_64: W: spelling-error %description -l en_US dmtcp -> Dmitri libdmtcpaware.x86_64: W: no-documentation libdmtcpaware-doc.x86_64: W: spelling-error %description -l en_US dmtcpaware -> Delaware 7 packages and 0 specfiles checked; 1 errors, 24 warnings. # echo 'rpmlint-done:' These are all fine. Requires -------- libdmtcpaware-devel (rpmlib, GLIBC filtered): libdmtcpaware(x86-64) libdmtcpaware.so.1()(64bit) libmtcp-devel (rpmlib, GLIBC filtered): libmtcp libmtcp.so.1()(64bit) libmtcp (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) libdmtcpaware-static (rpmlib, GLIBC filtered): libdmtcpaware-devel(x86-64) dmtcp (rpmlib, GLIBC filtered): ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libmtcp libpthread.so.0()(64bit) librt.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) libdmtcpaware (rpmlib, GLIBC filtered): /sbin/ldconfig dmtcp(x86-64) libc.so.6()(64bit) rtld(GNU_HASH) libdmtcpaware-doc (rpmlib, GLIBC filtered): libdmtcpaware-devel(x86-64) Provides -------- libdmtcpaware-devel: libdmtcpaware-devel libdmtcpaware-devel(x86-64) libmtcp-devel: libmtcp-devel libmtcp-devel(x86-64) libmtcp: libmtcp libmtcp(x86-64) libmtcp.so.1()(64bit) libdmtcpaware-static: libdmtcpaware-static libdmtcpaware-static(x86-64) dmtcp: dmtcp dmtcp(x86-64) dmtcphijack.so()(64bit) libdmtcpaware: libdmtcpaware libdmtcpaware(x86-64) libdmtcpaware.so.1()(64bit) libdmtcpaware-doc: libdmtcpaware-doc libdmtcpaware-doc(x86-64) Unversioned so-files -------------------- dmtcp: /usr/lib64/dmtcp/dmtcphijack.so MD5-sum check ------------- http://downloads.sourceforge.net/dmtcp/dmtcp-1.2.7.tar.gz : CHECKSUM(SHA256) this package : ce9ad548dd7d627120b6516a7c0e2f304c6eacaf2b17da13d8b0f5ea8d882f71 CHECKSUM(SHA256) upstream package : a5e1be2854787b7da78a7871b1b68886d5c42e431221110fe0a94a91256dfc4d diff -r also reports differences Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -b 750394 -m fedora-rawhide-x86_64 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TvIyY4p452&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review