Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954354 --- Comment #8 from Volker Fröhlich <volker27@xxxxxx> --- (In reply to comment #7) > I did notice that the README was in another language, but I > couldn't tell it was about something different by the same author until I > looked it up. For future reference, is it good practice to include docs > shipped in the source that are in another language? For example, if this > file was actually applicable to the package but it was in Russian, would I > want to include it in the package? Would I need to figure out the lang code > and mark it as README.ru or whatever code was appropriate? I think there are no strict rules for such cases. Your suggestions sound good to me. If documentation consumed a lot of space, you could create a custom sub-package per language or so. > > I'd also recommend to make it "%{_includedir}/zim/" in the files section, as > > that's more specific. Notice, there's no trailing asterisk! > > Fixed. What is the danger of using the asterisk? You wouldn't own the directory then. > > > It's common to leave one line empty between the different changelog entry > > blocks. > > Fixed. By the way, am I being too explicit in my comments or does that > matter? > I hadn't mentioned non-functional changes, like format changes or comments. > > [x]: Package is not known to require ExcludeArch. > > > > Builds on PPC and ARM > > Out of curiosity, how did you check this? Does Koji have this ability? I used ppc-koji and arm-koji to create scratch builds. > > [!]: Packages should try to preserve timestamps of original installed files. > > How can I fix this? You can try like Tom did here: https://bugzilla.redhat.com/show_bug.cgi?id=950172#c2 Please also tell upstream. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1ITTqoNr4O&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review