Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954354 --- Comment #7 from Micah Roth <micah.roth@xxxxxxxx> --- > Don't ship INSTALL, as it only contains generic installation instructions, > as of http://fedoraproject.org/wiki/Packaging:Guidelines#Documentation. > README seems to be about something completely unrelated. Changelog and NEWS > are empty. I usually don't ship empty files. Fixed. Heh, I did notice that the README was in another language, but I couldn't tell it was about something different by the same author until I looked it up. For future reference, is it good practice to include docs shipped in the source that are in another language? For example, if this file was actually applicable to the package but it was in Russian, would I want to include it in the package? Would I need to figure out the lang code and mark it as README.ru or whatever code was appropriate? > I'd also recommend to make it "%{_includedir}/zim/" in the files section, as > that's more specific. Notice, there's no trailing asterisk! Fixed. What is the danger of using the asterisk? > For the sake of simplicity, remove the empty %doc instruction from the devel > files section and remove the commented out BRs and Requires. Fixed. > It's common to leave one line empty between the different changelog entry > blocks. Fixed. By the way, am I being too explicit in my comments or does that matter? > [x]: Package is not known to require ExcludeArch. > > Builds on PPC and ARM Out of curiosity, how did you check this? Does Koji have this ability? > [!]: If (and only if) the source package includes the text of the license(s) > in its own file, then that file, containing the text of the license(s) > for the package is included in %doc. > > Add COPYING to the %doc section of the main package! Fixed. > [!]: License file installed when any subpackage combination is installed. > > See above! See above (; > [!]: Packages should try to preserve timestamps of original installed files. How can I fix this? > zimlib-devel.x86_64: E: changelog-time-in-future 2013-04-23 Timezone change ftw New URLS: Spec URL: http://multiseatlibrary.distract.org/files/zimlib.spec SRPM URL: http://multiseatlibrary.distract.org/files/zimlib-1.0-4.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7X1uhy2UMS&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review