Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894724 --- Comment #12 from T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> --- (In reply to comment #11) > Issues: > ======= > - Package is named according to the Package Naming Guidelines. > > I wonder if nodejs-tap or just tap is the correct name here? Earlier on we decided to rename because there are multiple implementations of the Test Anything Protocol (TAP). (The Perl version is probably more widely used. ;-) > - Patches link to upstream bugs/comments/lists or are otherwise justified. > - Spec file according to URL is the same as in SRPM. > > Need to make sure you use the version of the spec which has > the link to the bug as the spec in the srpm differed from the > separate spec on this. Sorry, forgot to rebuild after I added the upstream pull request link. > - Rpmlint is run on all installed packages. > > nodejs-tap.noarch: E: non-executable-script > /usr/lib/node_modules/tap/bin/tap-http.js 0644L /usr/bin/env Fixed. > nodejs-tap.noarch: W: no-manual-page-for-binary tap This is in my queue of man pages to write. --- Spec: http://patches.fedorapeople.org/npm/nodejs-tap.spec SRPM: http://patches.fedorapeople.org/npm/nodejs-tap-0.4.1-2.fc19.src.rpm * Tue Apr 23 2013 T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> - 0.4.1-2 - fix rpmlint warnings -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=D6ZvEmmuSo&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review