Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894724 --- Comment #11 from Tom Hughes <tom@xxxxxxxxxx> --- Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package is named according to the Package Naming Guidelines. I wonder if nodejs-tap or just tap is the correct name here? - Patches link to upstream bugs/comments/lists or are otherwise justified. - Spec file according to URL is the same as in SRPM. Need to make sure you use the version of the spec which has the link to the bug as the spec in the srpm differed from the separate spec on this. - Rpmlint is run on all installed packages. nodejs-tap.noarch: E: non-executable-script /usr/lib/node_modules/tap/bin/tap-http.js 0644L /usr/bin/env nodejs-tap.noarch: W: no-manual-page-for-binary tap ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [-]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [x]: Sources contain only permissible code or content. [-]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package complies to the Packaging Guidelines [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 1 files have unknown license. Detailed output of licensecheck in /home/tom/894724-nodejs-tap/licensecheck.txt [x]: Package consistently uses macro is (instead of hard-coded directory names). [!]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Large documentation must go in a -doc subpackage. Note: Documentation size is 30720 bytes in 10 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [-]: Buildroot is not present Note: Buildroot: present but not needed [-]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: nodejs-tap-0.4.1-1.fc20.noarch.rpm nodejs-tap.noarch: W: only-non-binary-in-usr-lib nodejs-tap.noarch: W: dangling-symlink /usr/lib/node_modules/tap/node_modules/buffer-equal /usr/lib/node_modules/buffer-equal nodejs-tap.noarch: W: dangling-symlink /usr/lib/node_modules/tap/node_modules/slide /usr/lib/node_modules/slide nodejs-tap.noarch: W: dangling-symlink /usr/lib/node_modules/tap/node_modules/mkdirp /usr/lib/node_modules/mkdirp nodejs-tap.noarch: W: dangling-symlink /usr/lib/node_modules/tap/node_modules/yamlish /usr/lib/node_modules/yamlish nodejs-tap.noarch: W: dangling-symlink /usr/lib/node_modules/tap/node_modules/runforcover /usr/lib/node_modules/runforcover nodejs-tap.noarch: W: dangling-symlink /usr/lib/node_modules/tap/node_modules/difflet /usr/lib/node_modules/difflet nodejs-tap.noarch: W: dangling-symlink /usr/lib/node_modules/tap/node_modules/deep-equal /usr/lib/node_modules/deep-equal nodejs-tap.noarch: W: dangling-symlink /usr/lib/node_modules/tap/node_modules/inherits /usr/lib/node_modules/inherits nodejs-tap.noarch: W: dangling-symlink /usr/lib/node_modules/tap/node_modules/glob /usr/lib/node_modules/glob nodejs-tap.noarch: E: non-executable-script /usr/lib/node_modules/tap/bin/tap-http.js 0644L /usr/bin/env nodejs-tap.noarch: W: dangling-symlink /usr/lib/node_modules/tap/node_modules/nopt /usr/lib/node_modules/nopt nodejs-tap.noarch: W: no-manual-page-for-binary tap 1 packages and 0 specfiles checked; 1 errors, 12 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint nodejs-tap nodejs-tap.noarch: W: only-non-binary-in-usr-lib nodejs-tap.noarch: W: dangling-symlink /usr/lib/node_modules/tap/node_modules/buffer-equal /usr/lib/node_modules/buffer-equal nodejs-tap.noarch: W: dangling-symlink /usr/lib/node_modules/tap/node_modules/slide /usr/lib/node_modules/slide nodejs-tap.noarch: W: dangling-symlink /usr/lib/node_modules/tap/node_modules/mkdirp /usr/lib/node_modules/mkdirp nodejs-tap.noarch: W: dangling-symlink /usr/lib/node_modules/tap/node_modules/yamlish /usr/lib/node_modules/yamlish nodejs-tap.noarch: W: dangling-symlink /usr/lib/node_modules/tap/node_modules/runforcover /usr/lib/node_modules/runforcover nodejs-tap.noarch: W: dangling-symlink /usr/lib/node_modules/tap/node_modules/difflet /usr/lib/node_modules/difflet nodejs-tap.noarch: W: dangling-symlink /usr/lib/node_modules/tap/node_modules/deep-equal /usr/lib/node_modules/deep-equal nodejs-tap.noarch: W: dangling-symlink /usr/lib/node_modules/tap/node_modules/inherits /usr/lib/node_modules/inherits nodejs-tap.noarch: W: dangling-symlink /usr/lib/node_modules/tap/node_modules/glob /usr/lib/node_modules/glob nodejs-tap.noarch: E: non-executable-script /usr/lib/node_modules/tap/bin/tap-http.js 0644L /usr/bin/env nodejs-tap.noarch: W: dangling-symlink /usr/lib/node_modules/tap/node_modules/nopt /usr/lib/node_modules/nopt nodejs-tap.noarch: W: no-manual-page-for-binary tap 1 packages and 0 specfiles checked; 1 errors, 12 warnings. # echo 'rpmlint-done:' Diff spec file in url and in SRPM --------------------------------- --- /home/tom/894724-nodejs-tap/srpm/nodejs-tap.spec 2013-04-23 08:26:38.176521868 +0100 +++ /home/tom/894724-nodejs-tap/srpm-unpacked/nodejs-tap.spec 2013-04-23 08:26:39.407519628 +0100 @@ -13,5 +13,5 @@ # the segv test results in SIGSEGV as you would expect, not SIGBUS as is written -# in the test: https://github.com/isaacs/node-tap/pull/75 +# in the test Patch1: nodejs-tap-segv-actually-segfaults.patch Requires -------- nodejs-tap (rpmlib, GLIBC filtered): /usr/bin/env nodejs(engine) npm(buffer-equal) npm(deep-equal) npm(difflet) npm(glob) npm(inherits) npm(mkdirp) npm(nopt) npm(runforcover) npm(slide) npm(yamlish) Provides -------- nodejs-tap: nodejs-tap npm(tap) MD5-sum check ------------- http://registry.npmjs.org/tap/-/tap-0.4.1.tgz : CHECKSUM(SHA256) this package : c36d102a16392bb405d136837db7268f059882ecf784ff9e7925e8999fbaa720 CHECKSUM(SHA256) upstream package : c36d102a16392bb405d136837db7268f059882ecf784ff9e7925e8999fbaa720 Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29 Buildroot used: compton-rawhide-x86_64 Command line :/usr/bin/fedora-review -m compton-rawhide-x86_64 -b 894724 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Sh5CkcO38M&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review