Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: zsh https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226813 ------- Additional Comments From james.antill@xxxxxxxxxx 2007-03-05 11:52 EST ------- > ok, but then do they need the #!/bin/zsh at the top of each file if they aren't going to be executed? They don't need it, I regard that as a comment saying "this is designed to work with zsh". I could remove the comment, or more likely make the files executable just to silence the warning ... I guess. It's kind of hacky but maybe the least resistence solution. > Can't RPM_SOURCE_DIR just be removed from that? The install section should be run with a current working dir of the top of the source dir I think... I'm not sure, I can try it to see. I tried to find documentation that told me of a better way to do that but couldn't find any ... so just left it alone. > > 2. W: zsh mixed-use-of-spaces-and-tabs (spaces: line 72, tab: line 108) > Only a nitpick. Remove if you like while making other changes. I looked at this, IMNSHO rpmlint needs to be fixed for this. The tab is in a string which is output, removing that would be very bad. I thought about changing it to use \t ... but I'd rather not change it at all, and rpmlint is certainly the wrong one here. I'll probably remove the patch, Colin added it in Jan, 2005 and it hasn't ever been enabled AFAICS. Is there policy text anywhere about why doing the dep. on /sbin/install-info is the right approach? Dito. %makeinstall ... I'd just like to know (and have it documented here) why that should change. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review