Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: plexus-runtime-builder-1.0-0.a9.2jpp - Plexus Component Descriptor Creator https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227105 tbento@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|tbento@xxxxxxxxxx |pcheung@xxxxxxxxxx Flag| |fedora-review- ------- Additional Comments From tbento@xxxxxxxxxx 2007-03-05 11:39 EST ------- X license field matches the actual license. This is MIT-Style license X license text included in package and marked with %doc no license marked with %doc No license text is included, or at least one that I could find. X rpmlint on <this package>.srpm gives no output W: plexus-runtime-builder non-standard-group Development/Java - this is OK W: plexus-runtime-builder mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 53) -please fix this When I run rpmlint on the source rpm, I don't get the mixed-used-of-spaces-and-tabs warning. X specfile is legible - should have %define _with_gcj_support 1 at the top of the spec file, please get rid of %define _with_gcj_support 0 and %define gcj_support 0 - the %define gcj_support .... doesn't seems like it can be split up into multiple lines I changed this, but I cannot build: java-gcj-compat-devel is needed by plexus-runtime-builder-1.0-0.1.a9.2jpp.1.i386 X make sure lines are <= 80 characters There are a couple of lines that are > 80, please fix those if possible. Fixed. Here are the links to the updated source rpm and spec file: SPEC FILE: https://tbento.108.redhat.com/files/documents/177/238/plexus-runtime-builder.spec SOURCE RPM: https://tbento.108.redhat.com/files/documents/177/239/plexus-runtime-builder-1.0-0.1.a9.2jpp.1.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review