Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951820 --- Comment #3 from Hans de Goede <hdegoede@xxxxxxxxxx> --- Hi, Thanks for the review! (In reply to comment #2) > [!]: Fully versioned dependency in subpackages, if present. > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in > libsidplayfp-devel-doc Note that the guidelines says "if present", iow the Requires on the main package (or other sub-packages) should be fully-versioned if such a requires is present. I see no reason for any Requires, if people want just the docs to do some reading while studying options for a new project (for example) they should be able to install just the docs. > Additional note: I recommend listing the soname explicitly rather than > using wildcards so that soname bumps are caught at build time but this is a > persnal preference. That is a good idea, I'll make that change in the next version. Regards, Hans -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=J7dBcZ2PuN&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review