Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951496 --- Comment #4 from Antonio Trande <anto.trande@xxxxxxxxx> --- (In reply to comment #3) > Thanks Antonio for the feedback. > > I have updated the spec and rebuilt the SRPM for the GPLv3+ license. > > The use of %{optflags} is problematic with this package. > > The makefile sets: > CFLAGS = -O3 -Wall $(shell gimptool-2.0 --cflags && pkg-config --cflags > lensfun exiv2) -fopenmp > > It's importing CFLAGS from gimptool and pkg-config that include links to > libraries via the -I flag. Therefore, a straight use of > CFLAGS="%{optflags}" breaks the build as the libraries cannot be found. > > I presume the gimp-lqr-plugin RPM had a similar issue as it also does not > use %{optflags}. > > I could still include %{optflags} if I run gimptool and pkg-config in the > spec file and pass the result into the call to make - would this be > preferred to omitting %{optflags} altogether? Try to: - Patch Makefile into %prep section with a simple replacement of "-O3 -Wall" with "@@OPTFLAGS@@" - In %build, add sed -e 's|@@OPTFLAGS@@|%{optflags}|g' -i Makefile' -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ITCzjDngEl&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review