Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951496 --- Comment #3 from Graham White <graham_alton@xxxxxxxxxxx> --- Thanks Antonio for the feedback. I have updated the spec and rebuilt the SRPM for the GPLv3+ license. The use of %{optflags} is problematic with this package. The makefile sets: CFLAGS = -O3 -Wall $(shell gimptool-2.0 --cflags && pkg-config --cflags lensfun exiv2) -fopenmp It's importing CFLAGS from gimptool and pkg-config that include links to libraries via the -I flag. Therefore, a straight use of CFLAGS="%{optflags}" breaks the build as the libraries cannot be found. I presume the gimp-lqr-plugin RPM had a similar issue as it also does not use %{optflags}. I could still include %{optflags} if I run gimptool and pkg-config in the spec file and pass the result into the call to make - would this be preferred to omitting %{optflags} altogether? I guess another approach would be for me to submit something upstream to alter their makefile so we can pass CFLAGS in more easily in the spec. The current git version of the makefile has changed from the release version I'm building here anyway but is still using gimptool and pkg-config in CFLAGS. If it's deemed best to leave %{optflags} out then I will add a comment to the spec to document why it's not there. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cp3EVfgXOy&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review