Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=916679 --- Comment #2 from Emmanuel Seyman <emmanuel@xxxxxxxxx> --- (In reply to comment #1) > Missing BRs: > perl(constant) from lib/ElasticSearch/RequestParser.pm:10,19 > perl(lib) from t/00-request.t:5 > perl(Data::Dumper) from lib/ElasticSearch/Error.pm:30 > perl(Encode) from lib/ElasticSearch/Transport.pm:11 and more > perl(Exporter) from lib/ElasticSearch/Util.pm:10 > perl(File::Path) from lib/ElasticSearch/TestServer.pm:14 > perl(File::Temp) from lib/ElasticSearch/TestServer.pm:11 > perl(IO::Handle) from lib/ElasticSearch/Transport.pm:14 > perl(IO::Socket) from lib/ElasticSearch/TestServer.pm:10 Added. > perl(JSON::XS) and perl(URI::Escape::XS) are not required for build, just > recommended for runtime. You can drop those deps. > perl(Task::Weaken) is not used anywhere. You can drop this dep too. Removed > Line 61 is unnecessary. Removed > Cosmetics: Since all the autoprovided modules are versioned, adding > %{version} to your explicit Provides would be great. You're right. Done. Spec URL: http://people.parinux.org/~seyman/fedora/perl-ElasticSearch/perl-ElasticSearch.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-ElasticSearch/perl-ElasticSearch-0.64-2.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1lxXNhZ1p5&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review