Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=916679 --- Comment #1 from Petr Šabata <psabata@xxxxxxxxxx> --- Missing BRs: perl(constant) from lib/ElasticSearch/RequestParser.pm:10,19 perl(lib) from t/00-request.t:5 perl(Data::Dumper) from lib/ElasticSearch/Error.pm:30 perl(Encode) from lib/ElasticSearch/Transport.pm:11 and more perl(Exporter) from lib/ElasticSearch/Util.pm:10 perl(File::Path) from lib/ElasticSearch/TestServer.pm:14 perl(File::Temp) from lib/ElasticSearch/TestServer.pm:11 perl(IO::Handle) from lib/ElasticSearch/Transport.pm:14 perl(IO::Socket) from lib/ElasticSearch/TestServer.pm:10 perl(JSON::XS) and perl(URI::Escape::XS) are not required for build, just recommended for runtime. You can drop those deps. perl(Task::Weaken) is not used anywhere. You can drop this dep too. Line 61 is unnecessary. Cosmetics: Since all the autoprovided modules are versioned, adding %{version} to your explicit Provides would be great. No other issues. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YvjPrQlV8k&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review