Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #61 from Paulo Andrade <paulo.cesar.pereira.de.andrade@xxxxxxxxx> --- (In reply to comment #60) > I won't post the full output of fedora-review again, just a short list of > items to be addressed. We're almost there! > > First, lrslib is listed as a Requires. The lrslib package contains only the > library. It looks like the lrs program is needed by > sage/geometry/polyhedron/base.py. In that case, the Requires should be for > lrslib-utils instead. Fixed. > Second, the license breakdown still needs to be explained in a comment: > https://fedoraproject.org/wiki/Packaging: > LicensingGuidelines#Multiple_Licensing_Scenarios > I know you said the license breakdown is available elsewhere, but it needs > to appear in the spec file, too. I belive I was missing only the comment about the breakdown before the License tag line, so, should be fixed now. I am a bit unsure if using GPL is valid as license, but I added it due to (http://www.wrongway.org/?rubiksource): ---%<--- The source code for my various rubik solvers are freely available. They are, for the moment, released GPL (e.g., free to distribute and modify but it and its derivitives must always remain free and open source). ---%<--- > Third, I did not make my meaning clear with the comment about one-line > scripts. You should have this: > > %post sagetex -p %{_bindir}/mktexlsr > %postun sagetex -p %{_bindir}/mktexlsr > > Note the use of -p. That allows RPM to invoke the program directly, rather > than spawning a shell to run the contents of the script. See > http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Syntax. Fixed. > Fourth, there is some new output from rpmlint that should be reviewed. Can > you take a look at these to see which are real issues that need to be > addressed? > > sagemath-core.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libcsage.so.0 /lib64/libm.so.6 I prefer to keep this in case there are a few of these python modules $ rpm -ql sagemath-core | grep '.so$' | wc -l 339 that do not "really" need to link to libcsage.so > sagemath-core.x86_64: E: zero-length > /usr/lib64/python2.7/site-packages/sage/server/notebook/compress/all.py > sagemath-core.x86_64: E: zero-length > /usr/lib64/python2.7/site-packages/sage/misc/test_cpickle_sage.py Removed in %install for the sake of silencing the warning. > sagemath-core.x86_64: W: dangling-symlink /usr/lib64/sagemath/devel/sage > /usr/lib64/python2.7/site-packages Fixed by moving the symlink to the -devel package. > sagemath-core.x86_64: E: zero-length > /usr/lib64/python2.7/site-packages/sage/libs/pari/to_gen.pxi > sagemath-data-extcode.noarch: W: dangling-symlink > /usr/share/sagemath/extcode/sage /usr/lib64/python2.7/site-packages I reworked the requires to have the symlink owned by the sagemath-data package, and add explicitly requires to the main package from sagemath-data. But it appears to not silence the warning, as I thought it was caused by the case of: a.bin -> requires package that provides /lib/foo a.noarch -> has symlink to /lib/foo a.bin -> requires a.noarch a.noarch -> does not require a.bin so, what I did was to make a.noarch require a.bin , but the warning remained. > sagemath-doc.noarch: W: only-non-binary-in-usr-lib > sagemath-doc.noarch: W: doc-file-dependency > /usr/share/doc/sagemath-5.8/common/update-python-inv.sh /usr/bin/env > sagemath-doc.noarch: W: doc-file-dependency > /usr/share/doc/sagemath-5.8/common/builder.py /usr/bin/env These are kind of documentation files also, that happen to be usable as scripts. Documentation is not supposed to be regenerated from installed packages, but possible with some tweaks. > sagemath-doc-en.noarch: W: spurious-executable-perm > /usr/share/doc/sagemath-5.8/en/prep/media/Rplot001.png Fixed. > sagemath-data.noarch: W: dangerous-command-in-%pretrans mv > sagemath-doc.noarch: W: dangerous-command-in-%pretrans mv > sagemath-notebook.x86_64: W: dangerous-command-in-%postun rm > sagemath-notebook.x86_64: W: dangerous-command-in-%posttrans ln I am keeping these a bit more for the sake of making clean upgrades after changing base dir to %{_libdir} for arch specific files, and after changing doc/data subpackages to noarch. This should be the last build with it, as I assume people using my f18 repository have upgraded to the latest version. This should not go in the final package. Just remind me, or yourself if you wish about ensuring those pretrans and posttrans are removed once the package is approved :-) > sagemath-rubiks.x86_64: W: spelling-error %description -l en_US contributers > -> contributes, contributors, contribute rs This is text from sagemath spkg.txt, I changed the spec for the sake of not having this warning again. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Cka0BCFzih&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review