Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #60 from Jerry James <loganjerry@xxxxxxxxx> --- I won't post the full output of fedora-review again, just a short list of items to be addressed. We're almost there! First, lrslib is listed as a Requires. The lrslib package contains only the library. It looks like the lrs program is needed by sage/geometry/polyhedron/base.py. In that case, the Requires should be for lrslib-utils instead. Second, the license breakdown still needs to be explained in a comment: https://fedoraproject.org/wiki/Packaging: LicensingGuidelines#Multiple_Licensing_Scenarios I know you said the license breakdown is available elsewhere, but it needs to appear in the spec file, too. Third, I did not make my meaning clear with the comment about one-line scripts. You should have this: %post sagetex -p %{_bindir}/mktexlsr %postun sagetex -p %{_bindir}/mktexlsr Note the use of -p. That allows RPM to invoke the program directly, rather than spawning a shell to run the contents of the script. See http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Syntax. Fourth, there is some new output from rpmlint that should be reviewed. Can you take a look at these to see which are real issues that need to be addressed? sagemath-core.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcsage.so.0 /lib64/libm.so.6 sagemath-core.x86_64: E: zero-length /usr/lib64/python2.7/site-packages/sage/server/notebook/compress/all.py sagemath-core.x86_64: E: zero-length /usr/lib64/python2.7/site-packages/sage/misc/test_cpickle_sage.py sagemath-core.x86_64: W: dangling-symlink /usr/lib64/sagemath/devel/sage /usr/lib64/python2.7/site-packages sagemath-core.x86_64: E: zero-length /usr/lib64/python2.7/site-packages/sage/libs/pari/to_gen.pxi sagemath-data.noarch: W: dangerous-command-in-%pretrans mv sagemath-data-extcode.noarch: W: dangling-symlink /usr/share/sagemath/extcode/sage /usr/lib64/python2.7/site-packages sagemath-doc.noarch: W: only-non-binary-in-usr-lib sagemath-doc.noarch: W: doc-file-dependency /usr/share/doc/sagemath-5.8/common/update-python-inv.sh /usr/bin/env sagemath-doc.noarch: W: doc-file-dependency /usr/share/doc/sagemath-5.8/common/builder.py /usr/bin/env sagemath-doc.noarch: W: dangerous-command-in-%pretrans mv sagemath-doc-en.noarch: W: spurious-executable-perm /usr/share/doc/sagemath-5.8/en/prep/media/Rplot001.png sagemath-notebook.x86_64: W: dangerous-command-in-%postun rm sagemath-notebook.x86_64: W: dangerous-command-in-%posttrans ln sagemath-rubiks.x86_64: W: spelling-error %description -l en_US contributers -> contributes, contributors, contribute rs -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UDPl4epC7p&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review