Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951360 --- Comment #2 from Stanislav Ochotnicky <sochotni@xxxxxxxxxx> --- Few points before I start complete review: * package doesn't build in mock. Please verify packages in mock before submitting reviews * Requires on nodejs and npm are most likely bogus. Requires on nodejs engine is generated automatically, and npm is most likely not needed for package to work correctly (or is it?) * Why would "cp -pr %{nodejs_sitelib} ." in check be needed? * Just for the record (this doesn't affect the review but FYI) following parts are not needed in Fedora/EL6+: * rm -rf %{buildroot} * whole %clean section * %defattr(-,root,root,-) (unless you really want to change defaults) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=U0Srb2BPNO&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review