Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=913367 --- Comment #4 from Eugene A. Pivnev <ti.eugene@xxxxxxxxx> --- BUGS: * %description: Description is smaller then Summary. * %post, %postun: "/bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null || :" is hack. Add hicolor-icon-theme to BuildRequires and Requires. * %files: As Fedora puts documents into %{_docdir}/%{name}-%{version} - replace current %doc expression with "share/doc/gpick/copyright" (patching SConstruct befor, naturally). Issues (not blockers): * Separate expressions inside sections something different then sections between each other. E.g. - double CR between sections and one CR between expression. Or one CR and no CR respectively. * You can replace BRs with "rpmname-independent" expressions: dbus-glib-devel => pkgconfig(dbus-glib-1) gtk2-devel => pkgconfig(gtk+-2.0) lua-devel => pkgconfig(lua) expat-devel => pkgconfig(expat) * You can replace "export ... scons..." with one line: "scons ... CFLAGS=... CXXFLAGS=..." * You can replace %{_usr} with %{_prefix} Questions: * Why lemon is needed? I created package without it. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7m9DQiq89n&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review