[Bug 950639] Review Request: c-ares19 - A library that performs asynchronous DNS operations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=950639

Jakub Hrozek <jhrozek@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(jhrozek@xxxxxxxxx |
                   |m)                          |

--- Comment #3 from Jakub Hrozek <jhrozek@xxxxxxxxxx> ---
Thank you for the autoconf patch, I'll start using it in Fedora c-ares package.

Here is the correct link to the new package:
http://sgallagh.fedorapeople.org/packagereview/c-ares19/c-ares19-1.9.1-4.fc18.2.src.rpm

Koji Build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5242026

rpmlint output:
c-ares19.ppc64: E: changelog-time-in-future 2013-04-12
c-ares19-debuginfo.ppc64: E: changelog-time-in-future 2013-04-12
c-ares19-devel.ppc64: E: changelog-time-in-future 2013-04-12
c-ares19-devel.ppc64: W: no-documentation
3 packages and 0 specfiles checked; 3 errors, 1 warnings.

The changelog in future is a simple specfile change that would be nice to get
done.
The no-documentation warning is OK, the man pages are removed on purpse.

* The package is named correctly given it's the 1.9 version
* Builds on all supported architectures (see the koji link)
* Smoke testing (a simple C program linked against c-ares19) worked fine
* Devel files are in the -devel package, file ownership seems sane
* Source tarballs' MD5 sums match:
  ** RPM      - 389db4917a3b58c4ce4ebfe961fd84c4
  ** upstream - 389db4917a3b58c4ce4ebfe961fd84c4

Fix the date in the changelog and I'll approve :-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=W6C8QtS7DH&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]