[Bug 950639] Review Request: c-ares19 - A library that performs asynchronous DNS operations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=950639

Stephen Gallagher <sgallagh@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?(jhrozek@xxxxxxxxx
                   |                            |m)

--- Comment #2 from Stephen Gallagher <sgallagh@xxxxxxxxxx> ---
SPEC: http://sgallagh.fedorapeople.org/packagereview/c-ares19/c-ares19.spec
SRPM:
http://sgallagh.fedorapeople.org/packagereview/c-ares19/c-ares19-1.9.1-4.fc18.1.src.rpm
KOJI:
http://sgallagh.fedorapeople.org/packagereview/c-ares19/c-ares19-1.9.1-4.fc18.1.src.rpm

So the reason for the debuginfo issue was that when I added autoreconf -if (to
process my changes to Makefile.am), it was overwriting the changes made by the
original patch c-ares-1.7.5-optflags.patch (which were written directly into
the configure script instead of configure.ac or its dependencies).

I added a patch that makes an equivalent modification to the
m4/cares-compilers.m4 and now it's producing appropriate debuginfo output (as
well as building with all the correct flags).

Jakub, you may want to convert to this approach in your Fedora package as well,
so you can run autoreconf in it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DDqq54lday&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]