Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=950907 --- Comment #2 from Robert Kuska <rkuska@xxxxxxxxxx> --- - Url shouldn't be link to source code, use [1]. - Fix python-devel to python2-devel [2]. - Rpmlint returns 'python-jedi.src: W: invalid-license LGPL', LGPLv3 is the right one [3], and few typos, use rpmlint on src.rpm. - I see that there are tests on github [4], did you run them before packaging? Also add please comment about tests run into spec file. [1] https://jedi.readthedocs.org/en/latest/index.html [2] https://fedoraproject.org/wiki/Packaging:Python#BuildRequires [3] https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Good_Licenses [4] https://github.com/davidhalter/jedi/tree/master/test -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Dv5Q6rt365&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review