Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=946856 --- Comment #2 from Lokesh Mandvekar <lsm5@xxxxxxxxxxx> --- First off, thanks for reviewing. Patches now supported with comments and links to bug reports ExclusiveArch and Provides gotten rid of All files in %files explicitly mentioned Changelog added $ rpmlint -i RPMS/x86_64/spectrwm-2.2.0-1.fc18.x86_64.rpm spectrwm.x86_64: W: no-soname /usr/lib64/libswmhack.so.0.0 1 packages and 0 specfiles checked; 0 errors, 1 warnings. ** Does this warning need to be taken care of? http://lists.fedoraproject.org/pipermail/devel/2012-April/166110.html mentions it's ok to skip invalid-soname, would it apply to no-soname as well ? $ rpmlint -i SRPMS/spectrwm-2.2.0-1.fc18.src.rpm spectrwm.src: W: %ifarch-applied-patch Patch1: spectrwm-2.2.0-lib64.patch A patch is applied inside an %ifarch block. Patches must be applied on all architectures and may contain necessary configure and/or code patch to be effective only on a given arch. 1 packages and 0 specfiles checked; 0 errors, 1 warnings. ** The lib64 patch makes sure the lib file gets installed to /usr/lib64 for x86_64, so that's why it's applied within %ifarch New successful koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5193463 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xgajs464Ki&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review